From cec30cb99edea89e88570d6fbaab8449f20d41c8 Mon Sep 17 00:00:00 2001
From: lucasdelimanogueira <lucasln96@hotmail.com>
Date: Wed, 1 May 2024 00:20:11 -0300
Subject: [PATCH] Fix autograd issue not backpropagating

---
 norch/__pycache__/tensor.cpython-38.pyc       | Bin 8465 -> 8339 bytes
 .../__pycache__/functions.cpython-38.pyc      | Bin 2222 -> 2229 bytes
 norch/autograd/functions.py                   |  14 ++++++------
 norch/tensor.py                               |  21 +++++++-----------
 test.py                                       |   9 ++++----
 5 files changed, 20 insertions(+), 24 deletions(-)

diff --git a/norch/__pycache__/tensor.cpython-38.pyc b/norch/__pycache__/tensor.cpython-38.pyc
index ab543df4ed58369f5771f86f7223da5d93eec4ca..058017d20cf4c115f058f367b2cd995dc1ff2cbf 100644
GIT binary patch
delta 632
zcmYk1J!}&}5QT5ne;0FiL3V6(#*Pgl2-6_`3u6e0lTZXf92<lnEKbe|j`7)ApM!+X
z0^yDVfu;Zn5dj6Eia;mPBT*tz<AOBQR8)w9ougrkPjB9vo!xmlh3ECEu16JlzI#Vk
z4}Q>Rwfm1{<tpn+H)<)1iVK#~RK+prfCX#NWa6;HNDZJ5w(0~dHh_m9^Pt~Za;4@$
z+i;bj^jtWtFj>nyB=ZsRh}5gF3$LNioCsCxs>=qfq%6g5us;6QjK~H(oe$usK7B4f
zA~NzzB0@+=47GC4b{ehvj1X-h#>vl;uP)bCns;l$8V2q)I>S)I?(`ho(F^I6j1>q&
zkg1@7##9ysHDE|;fM<={@Z8%nIKT@pvilGVU6$SN@I-8L|GZS<A|Xz=L>QA8MmX;}
zg7Yo>6)T6!<QH&0o`z3eBR&e@A~^<r&6xOXtPP)WJ9z|8CI0*$EF>qPg73{_xZ7Li
z{F}F(e8ZrK3uXnX_|}|&pZLXmpfAZ;c_t3f$SPh-r6GwMskvQKWZWba{3&*QjdK%!
zq~_qC(P?)%PkR^kRzQw@nV!j2sM}w~hrddc^H$Ai_3m(<^;l*a;J7zCeiERBZg#VH
uhOSH!{4EzrT_Id0(BA|n+#=KnD+G&B$DQ0Bv~&9)flqQ1u!<jZ*Z%?^)R=Gp

delta 762
zcmYk2O-vI(6vyXHx9w8f5-TEG3Je4cy&%RI2_KOUkr)kxQamU)Y`dklg%)SG8p$>o
z@#0N0S0&(CO>`6D(UVaRUbu1a>cPaAc=2G=H${!R+26eP{`0<8jy)WY%ts<2g3qJc
z$>m=!BIm;!yXd*3NbHbB=7<XxDe0mQBVa)uN<MMip%&eQyWo;--wvta`A-{1&3B*`
zwR&dSMV)Kqs7o|b)Lb}2DEgS=N4-J3RMvLDg&n9-C+Ln~X$wkJJaDO{88`|icR9Mc
zR%~$TCOt<MV+*wAt7)ze6SW-xa$`#koAk?1;fam)(V6nfZDwc96;m)LSGFs{W?8e$
zGC5YYa~5+d%n^lrJ||el%$9DM!eVQpvS#K@r%);P3BaF_42d>8L=dqbPF2fJVKp}?
zL`8^GD&DTpp+x;}5fMi>y6;;rtX&EIX)Ftoq3$k>69|AtbqIqFIz`eDeo<sty;Q!A
zT!+VAGRgtAz59*5)IWn+&*bjmt*(n`iAxGc6s8rL5c@&SZAWnaRNjoG0<$VUC_ls!
z@W%TbYlOhCibUmXn<0&+3cQp3%_romrXT+cdq+oMPCkz}2kdHw^N(JC^Aifga<3%~
zY1wP^z&AN<+|d`XR+5Ttxs+&;UyKH5mEVo2Lu0DN;z4IDBA4QRXqU_JDHz0}t<dSc
zkEa3abtER)oVr)vp^o|vA<kD#XSKS*dAD~jF##~(y=^-Ua6$fT-x?WGDQ6Yx>!p-6
luW(sG4JEEAaD^p>j6znyk|sMQzjky&T*g=r<m3Rm`Wsg{zDocA

diff --git a/norch/autograd/__pycache__/functions.cpython-38.pyc b/norch/autograd/__pycache__/functions.cpython-38.pyc
index 41695764a1e32e122763544f9d8176a7229ce476..0df507a5bb75673a08b47e884b67008d3c619178 100644
GIT binary patch
delta 169
zcmZ1{xK)rhl$V!_0SNTg8K&Kv$oqngH8ZcEv}EI712!ohpm+^qI%5q(JVOdYFhda&
zP@sqzNKE!(k4{tqGD?67vKX_NvY1mCB^jE5O0!r%tOcwK8AKS;8G{)#nf!_*fGRcF
zZn382<R_NgVk=3_E6y*v#gUw!2V|BM-(pEgEJ-Y40jj#inV*+h9G{b!om#{*c_Ewd
IWL}Pi0Dn>}jsO4v

delta 168
zcmdlgxK5Bal$V!_0SHp-4bxss<bA=xUXq$uoL^MD@wWk+8c3>!v4$a@A%!8Bp@<2{
z)nvTI22rBPRKx}pC}N+?$RRvAk=;H>3Z$GNi(vudLWUBi8pbS!EaohhEY@a55x91?
zB9N+EocVdF#ql|r*{Qc!({l0?OKx!_=jQ<pE-Ajnl9E`Gc#E|xF{gC$Klbea{IxFS

diff --git a/norch/autograd/functions.py b/norch/autograd/functions.py
index 67bc301..bbd8907 100644
--- a/norch/autograd/functions.py
+++ b/norch/autograd/functions.py
@@ -1,20 +1,20 @@
 class AddBackward:
     def __init__(self, x, y):
-        self.tensors = [x, y]
+        self.input = [x, y]
 
     def backward(self, gradient):
         return [gradient, gradient]
     
 class SubBackward:
     def __init__(self, x, y):
-        self.tensors = [x, y]
+        self.input = [x, y]
 
     def backward(self, gradient):
         return [gradient, -gradient]
     
 class ScalarMulBackward:
     def __init__(self, x, scalar):
-        self.tensors = [x]
+        self.input = [x]
         self.scalar = scalar
 
     def backward(self, gradient):
@@ -23,17 +23,17 @@ class ScalarMulBackward:
 
 class ElementwiseMulBackward:
     def __init__(self, x, y):
-        self.tensors = [x, y]
+        self.input = [x, y]
 
     def backward(self, gradient):
-        return [gradient * self.tensors[1], gradient * self.tensors[0]]
+        return [gradient * self.input[1], gradient * self.input[0]]
     
 class SumBackward:
     def __init__(self, x):
-        self.tensor = x
+        self.input = [x]
 
     def backward(self, gradient):
         # Since sum reduces a tensor to a scalar, gradient is broadcasted to match the original shape.
-        return self.tensor.ones_like() * float(gradient.tensor.contents.data.value)
+        return [float(gradient.tensor.contents.data[0]) * self.input[0].ones_like()]
 
 
diff --git a/norch/tensor.py b/norch/tensor.py
index 5103ec1..b615808 100644
--- a/norch/tensor.py
+++ b/norch/tensor.py
@@ -133,27 +133,22 @@ class Tensor:
             return
         
         if gradient is None:
-            if self.shape != [1]:
+            if self.shape == [1]:
+                gradient = Tensor([1])
+            else:
                 raise RuntimeError("Gradient argument must be specified for non-scalar tensors.")
-            gradient = self.ones_like()
-        
-        if self.shape != [1]:
-            raise RuntimeError("Only scalar tensors can be used to trigger backward propagation.")
-        
+
         if self.grad is None:
             self.grad = gradient
+
         else:
             self.grad += gradient
 
-        if self.grad_fn is not None:
+        if self.grad_fn is not None: # not a leaf
             grads = self.grad_fn.backward(gradient)
-            if len(grads) == 1:
-                self.grad = grads[0]
-            else:
-                for tensor, grad in zip(self.grad_fn.tensors, grads):
-                    tensor.backward(grad)
+            for tensor, grad in zip(self.grad_fn.input, grads):
+                tensor.backward(grad)
 
-    
     def zero_grad(self):
         self.grad = None
 
diff --git a/test.py b/test.py
index 56e4173..93aa5c7 100644
--- a/test.py
+++ b/test.py
@@ -29,10 +29,11 @@ if __name__ == "__main__":
 
     #d = b-c
 
-    c = a.sum()
-    c.backward()
-    print(a.grad)
-    print(b.grad)
+    c = a*b
+
+    d = c.sum()
+    d.backward()
+    print(c.grad)
     #print(a ** 2)
     
     """#print(a)