From 1f91bfc44206dfe89bef67ab353f81ed75f40568 Mon Sep 17 00:00:00 2001 From: Andrej Karpathy Date: Thu, 23 May 2024 18:19:25 +0000 Subject: [PATCH] fix small bug on eval logging --- train_gpt2.cu | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/train_gpt2.cu b/train_gpt2.cu index 8fd0093..585e82a 100644 --- a/train_gpt2.cu +++ b/train_gpt2.cu @@ -2635,9 +2635,9 @@ void logger_init(Logger *logger, const char *filename) { if (filename != NULL) { logger->logfile = fopenCheck(filename, "w"); } } -void logger_log_eval(Logger *logger, int step, float val_loss) { +void logger_log_eval(Logger *logger, int step, float val) { if (logger->logfile != NULL) { - fprintf(logger->logfile, "s:%d eval:%.4f\n", step, val_loss); + fprintf(logger->logfile, "s:%d eval:%.4f\n", step, val); } } @@ -2900,7 +2900,7 @@ int main(int argc, char *argv[]) { // careful because not all ranks may have the exact same allocation of number of examples eval_acc_norm = multi_gpu_cpu_float_sum(eval_acc_norm); printf0("HellaSwag: %d/%d = %f\n", (int)eval_acc_norm, eval_loader.num_examples, eval_acc_norm / eval_loader.num_examples); - logger_log_eval(&logger, step, eval_acc_norm); + logger_log_eval(&logger, step, eval_acc_norm / eval_loader.num_examples); } // once in a while do model inference to print generated text