comp-chem/cp2k
1
0
Fork 0
mirror of https://github.com/cp2k/cp2k.git synced 2026-07-28 06:05:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Precommit: check for CPASSERT(.FALSE.), and empty CPABORT() (#5491)

Browse source
This commit is contained in:
HE Zilong 2026-07-03 18:09:01 +08:00 • committed by GitHub
parent bfcb1ea1d6
commit d275998fba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
142 changed files with 616 additions and 597 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tools/precommit/check_file_properties.py
View file

@ -205,12 +205,7 @@ def check_file(path: pathlib.Path) -> List[str]:
if "\r\n" in content:
warnings += [f"{path}: contains DOS linebreaks"]
if (
fn_ext not in (".pot", ".patch")
and basefn != "Makefile"
and basefn != "generate_arch_files.sh"
and "\t" in content
):
if fn_ext not in (".pot", ".patch") and basefn != "Makefile" and "\t" in content:
warnings += [f"{path}: contains tab character"]
if fn_ext == ".cu" and "#if defined(_OMP_H)\n#error" not in content:
@ -224,6 +219,18 @@ def check_file(path: pathlib.Path) -> List[str]:
if STR_END_SPACE_RE.search(a) and STR_BEGIN_SPACE_RE.search(b):
warnings += [f"{path}:{i+1} Double space in multi-line string"]
# Check CPASSERT(.FALSE.) and empty CPABORT() messages
suppress_cpabort = ["semi_empirical_int_debug.F"]
if fn_ext == ".F" and basefn not in suppress_cpabort:
if "CPASSERT(.FALSE.)" in content:
warnings += [
f"{path}: Found CPASSERT(.FALSE.) - please use CPABORT() with messages"
]
if "CPABORT('')" in content or 'CPABORT("")' in content:
warnings += [
f"{path}: Found CPABORT() with empty message - please fill in the reason"
]
# check banner
year = datetime.now(timezone.utc).year
bsd_licensed = any(str(path).startswith(p) for p in BSD_PATHS)