crp/OpenMC
1
0
Fork 0
mirror of https://github.com/openmc-dev/openmc.git synced 2026-07-27 05:35:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2479 from pshriwise/improve-trigger-msg

Browse source 
Provide alternative batch estimation message
This commit is contained in:
Paul Romano 2023-04-18 06:27:47 -05:00 • committed by GitHub
commit 1afe4294fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/tallies/trigger.cpp
View file

@ -39,7 +39,8 @@ std::pair<double, double> get_tally_uncertainty(
auto mean = sum / n;
// if the result has no contributions, return an invalid pair
if (mean == 0) return {-1 , -1};
if (mean == 0)
return {-1, -1};
double std_dev = std::sqrt((sum_sq / n - mean * mean) / (n - 1));
double rel_err = (mean != 0.) ? std_dev / std::abs(mean) : 0.;
@ -193,8 +194,10 @@ void check_triggers()
keff_ratio);
} else {
if (tally_ratio == INFINITY) {
msg = fmt::format("Triggers unsatisfied, no result tallied for score {} in tally {}", reaction_name(score), tally_id);
} else{
msg = fmt::format(
"Triggers unsatisfied, no result tallied for score {} in tally {}",
reaction_name(score), tally_id);
} else {
msg = fmt::format(
"Triggers unsatisfied, max unc./thresh. is {} for {} in tally {}",
tally_ratio, reaction_name(score), tally_id);
@ -211,13 +214,20 @@ void check_triggers()
auto n_pred_batches = static_cast<int>(n_active * max_ratio * max_ratio) +
settings::n_inactive + 1;
std::string msg =
fmt::format("The estimated number of batches is {}", n_pred_batches);
if (n_pred_batches > settings::n_max_batches) {
msg.append(" --- greater than max batches");
warning(msg);
} else {
if (max_ratio == INFINITY) {
std::string msg =
fmt::format("One or more tallies with triggers have no scores. Unable "
"to estimate the number of remaining batches.");
write_message(msg, 7);
} else {
std::string msg =
fmt::format("The estimated number of batches is {}", n_pred_batches);
if (n_pred_batches > settings::n_max_batches) {
msg.append(" --- greater than max batches");
warning(msg);
} else {
write_message(msg, 7);
}
}
}
}