crp/OpenMC
1
0
Fork 0
mirror of https://github.com/openmc-dev/openmc.git synced 2026-07-28 06:05:58 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Merge pull request #1464 from smharper/tiny_bit_mesh_bug

Browse source 
Ensure a valid bin is picked for short tracks in tally meshes
This commit is contained in:
Paul Romano 2020-01-25 23:41:46 -06:00 • committed by GitHub
commit 2e73b9553b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/mesh.cpp
View file

@ -530,9 +530,11 @@ void RegularMesh::bins_crossed(const Particle* p, std::vector<int>& bins,
// The TINY_BIT offsets above mean that the preceding logic cannot always find
// the correct ijk0 and ijk1 indices. For tracks shorter than 2*TINY_BIT, just
// assume the track lies in only one mesh bin. These tracks are very short so
// any error caused by this assumption will be small.
// any error caused by this assumption will be small. It is important that
// ijk0 values are used rather than ijk1 because the previous logic guarantees
// ijk0 is a valid mesh bin.
if (total_distance < 2*TINY_BIT) {
for (int i = 0; i < n; ++i) ijk0[i] = ijk1[i];
for (int i = 0; i < n; ++i) ijk1[i] = ijk0[i];
}
// ========================================================================
@ -917,9 +919,11 @@ void RectilinearMesh::bins_crossed(const Particle* p, std::vector<int>& bins,
// The TINY_BIT offsets above mean that the preceding logic cannot always find
// the correct ijk0 and ijk1 indices. For tracks shorter than 2*TINY_BIT, just
// assume the track lies in only one mesh bin. These tracks are very short so
// any error caused by this assumption will be small.
// any error caused by this assumption will be small. It is important that
// ijk0 values are used rather than ijk1 because the previous logic guarantees
// ijk0 is a valid mesh bin.
if (total_distance < 2*TINY_BIT) {
for (int i = 0; i < 3; ++i) ijk0[i] = ijk1[i];
for (int i = 0; i < 3; ++i) ijk1[i] = ijk0[i];
}
// ========================================================================