crp/OpenMC
1
0
Fork 0
mirror of https://github.com/openmc-dev/openmc.git synced 2026-07-29 06:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Apply suggestions from code review

Browse source 
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
This commit is contained in:
Ethan Peterson 2022-08-04 16:50:18 -04:00 • committed by GitHub
parent 152a149488
commit 39eaf9d887
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
openmc/material.py
View file

@ -899,7 +899,7 @@ class Material(IDManagerMixin):
return nuclides
def get_activity(self, normalization: str = 'total', by_nuclide: bool = False):
def get_activity(self, normalization: str = 'volume', by_nuclide: bool = False):
"""Returns the activity of the material or for each nuclide in the
material in units of [Bq], [Bq/g] or [Bq/cc].

14
tests/unit_tests/test_material.py
View file

@ -483,33 +483,33 @@ def test_get_activity():
assert m1.get_activity(normalization='volume') == 0
assert m1.get_activity(normalization='mass') == 0
m1.volume = 1
assert m1.get_activity() == 0
assert m1.get_activity(normalization='total') == 0
# Checks that 1g of tritium has the correct activity scaling
m2 = openmc.Material()
m2.add_nuclide("H3", 1)
m2.set_density('g/cm3', 1)
m2.volume = 1
assert pytest.approx(m2.get_activity()) == 3.559778e14
assert pytest.approx(m2.get_activity(normalization='total')) == 3.559778e14
m2.set_density('g/cm3', 2)
assert pytest.approx(m2.get_activity()) == 3.559778e14*2
assert pytest.approx(m2.get_activity(normalization='total')) == 3.559778e14*2
m2.volume = 3
assert pytest.approx(m2.get_activity()) == 3.559778e14*2*3
assert pytest.approx(m2.get_activity(normalization='total')) == 3.559778e14*2*3
# Checks that 1 mol of a metastable nuclides has the correct activity
m3 = openmc.Material()
m3.add_nuclide("Tc99_m1", 1)
m3.set_density('g/cm3', 1)
m3.volume = 98.9
assert pytest.approx(m3.get_activity(), rel=0.001) == 1.93e19
assert pytest.approx(m3.get_activity(normalization='total'), rel=0.001) == 1.93e19
# Checks that specific and volumetric activity of tritium are correct
m4 = openmc.Material()
m4.add_nuclide("H3", 1)
m4.set_density('g/cm3', 1.5)
assert m4.get_activity(normalization='mass') == 355978108155966.0*2/3 # [Bq/g]
assert m4.get_activity(normalization='mass') == 355978108155965.94 # [Bq/g]
assert m4.get_activity(normalization='mass', by_nuclide=True) == {
"H3": 355978108155966.0*2/3 # [Bq/g]
"H3": 355978108155965.94 # [Bq/g]
}
assert m4.get_activity(normalization='volume') == 355978108155965.94*3/2 # [Bq/cc]
assert m4.get_activity(normalization='volume', by_nuclide=True) == {