From 3e61076715b9a15285b2d731127b968c600d7812 Mon Sep 17 00:00:00 2001 From: Patrick Shriwise Date: Sat, 25 Jun 2022 14:38:19 +0200 Subject: [PATCH] Changing check for Tabular to use std. dev. --- tests/unit_tests/test_stats.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/unit_tests/test_stats.py b/tests/unit_tests/test_stats.py index f789a0dca7..87d8118812 100644 --- a/tests/unit_tests/test_stats.py +++ b/tests/unit_tests/test_stats.py @@ -165,14 +165,26 @@ def test_tabular(): n_samples = 100_000 samples = d.sample(n_samples, seed=100) - assert samples.mean() == pytest.approx(d.mean(), rel=1e-03) + diff = np.abs(samples - d.mean()) + # within_1_sigma = np.count_nonzero(diff < samples.std()) + # assert within_1_sigma / n_samples >= 0.68 + within_2_sigma = np.count_nonzero(diff < 2*samples.std()) + assert within_2_sigma / n_samples >= 0.95 + within_3_sigma = np.count_nonzero(diff < 3*samples.std()) + assert within_3_sigma / n_samples >= 0.99 # test histogram sampling d = openmc.stats.Tabular(x, p, interpolation='histogram') d.normalize() samples = d.sample(n_samples, seed=100) - assert samples.mean() == pytest.approx(d.mean(), rel=1e-03) + diff = np.abs(samples - d.mean()) + # within_1_sigma = np.count_nonzero(diff < samples.std()) + # assert within_1_sigma / n_samples >= 0.68 + within_2_sigma = np.count_nonzero(diff < 2*samples.std()) + assert within_2_sigma / n_samples >= 0.95 + within_3_sigma = np.count_nonzero(diff < 3*samples.std()) + assert within_3_sigma / n_samples >= 0.99 def test_legendre():