From 42696ed4ef2f295d9dc142445604530c950e98a4 Mon Sep 17 00:00:00 2001 From: shimwell Date: Sun, 5 Apr 2026 11:00:03 +0200 Subject: [PATCH] raise value error if nuc not found --- openmc/deplete/chain.py | 10 ++++++++++ tests/unit_tests/test_deplete_chain.py | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/openmc/deplete/chain.py b/openmc/deplete/chain.py index 20f79531e9..cd43db145f 100644 --- a/openmc/deplete/chain.py +++ b/openmc/deplete/chain.py @@ -1251,7 +1251,17 @@ class Chain: Names of all radioactive decay daughters reachable from the parent. + Raises + ------ + ValueError + If the nuclide is not present in the chain. + """ + if nuclide not in self.nuclide_dict: + raise ValueError( + f"Cannot find decay daughters for '{nuclide}': " + "nuclide is not in the chain." + ) daughters = set() stack = [nuclide] visited = set() diff --git a/tests/unit_tests/test_deplete_chain.py b/tests/unit_tests/test_deplete_chain.py index 92e4195942..6214d9e45d 100644 --- a/tests/unit_tests/test_deplete_chain.py +++ b/tests/unit_tests/test_deplete_chain.py @@ -607,9 +607,9 @@ def test_get_decay_daughters(gnd_simple_chain): daughters = gnd_simple_chain.get_decay_daughters("Cs135") assert daughters == set() - # Nuclide not in chain returns empty set - daughters = gnd_simple_chain.get_decay_daughters("Xx999") - assert daughters == set() + # Nuclide not in chain raises ValueError + with pytest.raises(ValueError, match="not in the chain"): + gnd_simple_chain.get_decay_daughters("Xx999") def test_get_decay_daughters_cyclic(simple_chain):