From 5555cfd1aaefcccdc9dcaeba847dc8d38ee21dc0 Mon Sep 17 00:00:00 2001 From: Paul Romano Date: Fri, 30 Sep 2016 14:44:44 -0500 Subject: [PATCH] Respond to @smharper comments on #721 --- openmc/data/nbody.py | 4 ++-- openmc/data/reaction.py | 4 +--- openmc/data/reconstruct.pyx | 4 ++-- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/openmc/data/nbody.py b/openmc/data/nbody.py index 6616b1858..b186c253a 100644 --- a/openmc/data/nbody.py +++ b/openmc/data/nbody.py @@ -18,7 +18,7 @@ class NBodyPhaseSpace(AngleEnergy): atomic_weight_ratio : float Atomic weight ratio of target nuclide q_value : float - Q value for reaction in MeV + Q value for reaction in MeV or eV, depending on the data source. Attributes ---------- @@ -29,7 +29,7 @@ class NBodyPhaseSpace(AngleEnergy): atomic_weight_ratio : float Atomic weight ratio of target nuclide q_value : float - Q value for reaction in MeV + Q value for reaction in MeV or eV, depending on the data source. """ diff --git a/openmc/data/reaction.py b/openmc/data/reaction.py index cef635135..fa55fbab9 100644 --- a/openmc/data/reaction.py +++ b/openmc/data/reaction.py @@ -663,9 +663,7 @@ class Reaction(EqualityMixin): mt : int The ENDF MT number for this reaction. q_value : float - The Q-value of this reaction in MeV. - threshold : float - Threshold of the reaction in MeV + The Q-value of this reaction in MeV or eV, depending on the data source. xs : dict of str to openmc.data.Function1D Microscopic cross section for this reaction as a function of incident energy; these cross sections are provided in a dictionary where the key diff --git a/openmc/data/reconstruct.pyx b/openmc/data/reconstruct.pyx index 452968d14..f63a155b1 100644 --- a/openmc/data/reconstruct.pyx +++ b/openmc/data/reconstruct.pyx @@ -15,8 +15,8 @@ cdef extern from "complex.h": double complex cexp(double complex) # Physical constants are from CODATA 2014 -cdef double NEUTRON_MASS_ENERGY = 939.5654133e6 # MeV/c^2 -cdef double HBAR_C = 197.3269788e5 # MeV-b^0.5 +cdef double NEUTRON_MASS_ENERGY = 939.5654133e6 # eV/c^2 +cdef double HBAR_C = 197.3269788e5 # eV-b^0.5 @cython.cdivision(True)