PR comments addressed

This commit is contained in:
Gavin Ridley 2023-04-15 13:01:01 -04:00
parent f202377fb7
commit 62708ab3ad
3 changed files with 5 additions and 10 deletions

View file

@ -24,14 +24,14 @@ vector<int64_t> calculate_parallel_index_vector(const int64_t size)
#ifdef OPENMC_MPI
result.resize(n_procs);
vector<int64_t> bank_size(n_procs);
result[0] = 0;
vector<int64_t> bank_size(n_procs + 1);
// Populate the result with cumulative sum of the number of
// surface source banks per process
MPI_Scan(&size, bank_size.data(), 1, MPI_INT64_T, MPI_SUM, intracomm);
MPI_Allgather(
bank_size.data(), 1, MPI_INT64_T, result.data(), 1, MPI_INT64_T, intracomm);
result.insert(result.begin(), 0);
MPI_Allgather(bank_size.data() + 1, 1, MPI_INT64_T, result.data(), 1,
MPI_INT64_T, intracomm);
#else
result.push_back(0);
result.push_back(size);

View file

@ -390,12 +390,6 @@ void print_build_info()
#ifdef COVERAGEBUILD
coverage = y;
#endif
#ifdef NCRYSTAL
ncrystal = y;
#endif
#ifdef OPENMC_MCPL
mcpl = y;
#endif
// Wraps macro variables in quotes
#define STRINGIFY(x) STRINGIFY2(x)

View file

@ -11,6 +11,7 @@ TEST_CASE("Test get_file_extension")
REQUIRE(get_file_extension("has_directory/asdf.20.h5") == "h5");
REQUIRE(get_file_extension("wasssssup_lol") == "");
REQUIRE(get_file_extension("has_directory/secret_file") == "");
REQUIRE(get_file_extension("lovely.dir/extensionless_file") == "");
}
TEST_CASE("Test dir_exists")