crp/OpenMC
1
0
Fork 0
mirror of https://github.com/openmc-dev/openmc.git synced 2026-07-28 22:26:08 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

address comments from @hassec review

Browse source
This commit is contained in:
Ethan Peterson 2023-02-06 15:52:46 -05:00
parent c07386fc62
commit 637080a0c2
1 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
openmc/model/surface_composite.py
View file

@ -816,9 +816,14 @@ class Polygon(CompositeSurface):
# segment, but is not coincident with either of the points
# 2: 2 points are coincident, but the line segments are not
# collinear which guarantees no intersection
# 3: not possible
# 3: not possible, except maybe floating point issues?
# 4: Both line segments are collinear, simply need to check if
# they overlap or not
# adapted from algorithm linked below and modified to only
# consider intersections on the interior of line segments as
# proper intersections: i.e. segments sharing end points do not
# count as intersections.
# https://www.geeksforgeeks.org/check-if-two-given-line-segments-intersect/
if num_zeros == 0:
# If the orientations of p0 and p1 have opposite signs
@ -839,7 +844,12 @@ class Polygon(CompositeSurface):
elif num_zeros == 2:
continue
elif num_zeros == 4:
elif num_zeros == 3:
warnings.warn('Unclear if Polygon is self-intersecting')
continue
else:
# All 4 cross products are zero
# Determine number of unique points, x span and y span for
# both line segments
#unique_pts = np.unique(np.vstack((p0, p1, p2, p3)), axis=0)
@ -853,9 +863,6 @@ class Polygon(CompositeSurface):
raise ValueError('Polygon cannot be self-intersecting')
continue
else:
warnings.warn('Unclear if Polygon is self-intersecting')
return points
def _constrain_triangulation(self, points, depth=0):