Add destructors that remove key-value pairs from maps

include/openmc/material.h

@@ -43,9 +43,10 @@ public:
     double fraction; //!< How often to use table
   };
 
-  // Constructors
+  // Constructors and destructors
   Material() {};
   explicit Material(pugi::xml_node material_node);
+  ~Material();
 
   // Methods
   void calculate_xs(Particle& p) const;

include/openmc/tallies/filter.h

@@ -62,7 +62,7 @@ public:
   //! \return Pointer to the new filter object
   static Filter* create(pugi::xml_node node);
 
-  virtual ~Filter() = default;
+  virtual ~Filter();
 
   virtual std::string type() const = 0;
 

include/openmc/tallies/tally.h

@@ -25,6 +25,8 @@ class Tally {
 public:
   explicit Tally(int32_t id);
 
+  ~Tally();
+
   static Tally* create(int32_t id = -1);
 
   void init_from_xml(pugi::xml_node node);

src/material.cpp

@@ -332,6 +332,11 @@ Material::Material(pugi::xml_node node)
   }
 }
 
+Material::~Material()
+{
+  model::material_map.erase(id_);
+}
+
 void Material::finalize()
 {
   // Set fissionable if any nuclide is fissionable

src/tallies/filter.cpp

@@ -63,6 +63,11 @@ extern "C" size_t tally_filters_size()
 Filter::Filter() : index_{model::tally_filters.size()}
 { }
 
+Filter::~Filter()
+{
+  model::filter_map.erase(id_);
+}
+
 Filter* Filter::create(pugi::xml_node node)
 {
   // Copy filter id

src/tallies/tally.cpp

@@ -247,6 +247,11 @@ Tally::Tally(int32_t id)
   this->set_filters({});
 }
 
+Tally::~Tally()
+{
+  model::tally_map.erase(id_);
+}
+
 Tally*
 Tally::create(int32_t id)
 {