Address most @pshriwise comments on #1538

openmc/mgxs/mgxs.py

@@ -14,7 +14,7 @@ from openmc.mgxs import EnergyGroups
 
 
 # Supported cross section types
-MGXS_TYPES = [
+MGXS_TYPES = (
     'total',
     'transport',
     'nu-transport',
@@ -37,16 +37,16 @@ MGXS_TYPES = [
     'inverse-velocity',
     'prompt-nu-fission',
     'prompt-nu-fission matrix'
-]
+)
 
 # Supported domain types
-DOMAIN_TYPES = [
+DOMAIN_TYPES = (
     'cell',
     'distribcell',
     'universe',
     'material',
     'mesh'
-]
+)
 
 # Filter types corresponding to each domain
 _DOMAIN_TO_FILTER = {

openmc/model/triso.py

@@ -17,8 +17,8 @@ import openmc
 from openmc.checkvalue import check_type
 
 
-MAX_PF_RSP = 0.38
-MAX_PF_CRP = 0.64
+MAX_PF_RSP = 0.38  # maximum packing fraction for random sequential packing
+MAX_PF_CRP = 0.64  # maximum packing fraction for close random packing
 
 
 def _volume_sphere(r):

openmc/summary.py

@@ -90,8 +90,7 @@ class Summary:
     def _read_macroscopics(self):
         if 'macroscopics/names' in self._f:
             names = self._f['macroscopics/names'][()]
-            for name in names:
-                self._macroscopics.append(name.decode())
+            self._macroscopics = [name.decode() for name in names]
 
     def _read_geometry(self):
         with warnings.catch_warnings():