crp/OpenMC
1
0
Fork 0
mirror of https://github.com/openmc-dev/openmc.git synced 2026-07-28 06:05:58 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Apply suggestions from code review

Browse source 
Co-Authored-By: Sterling Harper <sterlingmharper@gmail.com>
This commit is contained in:
Giud 2019-11-03 14:57:44 -05:00 • committed by GitHub
parent 6e4e69075b
commit b08933a653
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
openmc/cell.py
View file

@ -415,12 +415,12 @@ class Cell(IDManagerMixin):
Parameters
----------
clone_materials : boolean
Whether to create separates copies of the materials filling cells
clone_materials : bool
Whether to create separate copies of the materials filling cells
contained in this cell, or the material filling this cell.
Default is True.
clone_regions : boolean
Whether to create separates copies of the regions bounding cells
clone_regions : bool
Whether to create separate copies of the regions bounding cells
contained in this cell, and the region bounding this cell.
Default is True.
memo : dict or None

18
openmc/lattice.py
View file

@ -455,11 +455,11 @@ class Lattice(IDManagerMixin, metaclass=ABCMeta):
Parameters
----------
clone_materials : boolean
Whether to create separates copies of the materials filling cells
clone_materials : bool
Whether to create separate copies of the materials filling cells
contained in this lattice and its outer universe. Default is True.
clone_regions : boolean
Whether to create separates copies of the regions bounding cells
clone_regions : bool
Whether to create separate copies of the regions bounding cells
contained in this lattice and its outer universe. Default is True.
memo : dict or None
A nested dictionary of previously cloned objects. This parameter
@ -787,9 +787,9 @@ class RectLattice(Lattice):
Parameters
----------
strategy : String
strategy : str
Which strategy to adopt when discretizing the lattice
rotate_universe_with_neighbors : boolean
rotate_universe_with_neighbors : bool
Whether lattice universes (especially sublattices) with rotated/
symmetric neighbor patterns should also be rotated/symmetrized.
Default is False.
@ -797,12 +797,12 @@ class RectLattice(Lattice):
Lattice universes that need not be discretized
materials_to_clone : Iterable of Material
List of materials that should be cloned when discretizing
lattice_neighbors : Iterable of Integral or String
lattice_neighbors : Iterable of Integral or str
List of attributes of the lattice's neighbors. By default, if
present, the lattice outer universe will be used. The neighbors
are represented as follows [top left, top, top right, left, right,
bottom left, bottom, bottom right]
attribute : String
attribute : str
Which universe attribute to use when detecting neighbor symmetry
patterns. Can be the 'id' or the 'name' of the lattice universes
@ -1007,7 +1007,7 @@ class RectLattice(Lattice):
clone_materials=False, clone_regions=False)
# Call LNS on the immediate sub lattices of this universe
for cell_id, sub_cell in new_universe.cells.items():
for sub_cell in new_universe.cells.values():
sub_universe = sub_cell.fill

4
openmc/universe.py
View file

@ -483,10 +483,10 @@ class Universe(IDManagerMixin):
Parameters
----------
clone_materials : boolean
clone_materials : bool
Whether to create separates copies of the materials filling cells
contained in this universe. Default is True.
clone_regions : boolean
clone_regions : bool
Whether to create separates copies of the regions bounding cells
contained in this universe. Default is True.
memo : dict or None