From c7399d0d1d4205be9553254108d87d3c5ab9d5a4 Mon Sep 17 00:00:00 2001 From: John Tramm Date: Wed, 20 Nov 2019 20:07:27 +0000 Subject: [PATCH] Fixed MPI by changing the indexing scheme for reading from the source bank. Previously, it was doing index_source -1, with index source starting at 0, which was causing undefined behavior. Now, it uses index_source properly. This may have been an artifact from Fortran days? --- src/simulation.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/simulation.cpp b/src/simulation.cpp index 7c548bcbaa..dee0338878 100644 --- a/src/simulation.cpp +++ b/src/simulation.cpp @@ -1106,8 +1106,10 @@ void finalize_generation() void initialize_history(Particle* p, int64_t index_source) { + //assert(index_source - 1 >= 0 ); // set defaults - p->from_source(&simulation::source_bank[index_source - 1]); + //p->from_source(&simulation::source_bank[index_source - 1]); + p->from_source(&simulation::source_bank[index_source]); // set identifier for particle p->id_ = simulation::work_index[mpi::rank] + index_source;