From c907c8567590e5e38ca6a4e07c7f176c6a0d0fa9 Mon Sep 17 00:00:00 2001 From: Paul Romano Date: Sat, 8 Apr 2023 14:38:10 +0200 Subject: [PATCH] Improve error message regarding particle filter --- src/tallies/tally.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/tallies/tally.cpp b/src/tallies/tally.cpp index 94bfc6cd4..8056b2574 100644 --- a/src/tallies/tally.cpp +++ b/src/tallies/tally.cpp @@ -191,9 +191,9 @@ Tally::Tally(pugi::xml_node node) case SCORE_DELAYED_NU_FISSION: case SCORE_PROMPT_NU_FISSION: case SCORE_DECAY_RATE: - warning("Particle filter is not used with photon transport" - " on and " + - reaction_name(score) + " score."); + warning("You are tallying the '" + reaction_name(score) + + "' score and haven't used a particle filter. This score will " + "include contributions from all particles."); break; } } @@ -1283,7 +1283,8 @@ extern "C" int openmc_remove_tally(int32_t index) if (index < 0 || index > model::tallies.size()) { return OPENMC_E_OUT_OF_BOUNDS; } - // grab tally so it's ID can be obtained to remove the (ID,index) pair from tally_map + // grab tally so it's ID can be obtained to remove the (ID,index) pair from + // tally_map auto& tally = model::tallies[index]; // delete the tally via iterator pointing to correct position // this calls the Tally destructor, removing the tally from the map as well