From d409e99eb054466a8056896c9bb27980a7ebf96e Mon Sep 17 00:00:00 2001 From: rockfool Date: Tue, 17 Mar 2020 15:41:17 -0400 Subject: [PATCH] address comments from reviewers --- openmc/polynomial.py | 5 ++--- tests/unit_tests/test_polynomials.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/openmc/polynomial.py b/openmc/polynomial.py index 24742b8e35..82a6756c82 100644 --- a/openmc/polynomial.py +++ b/openmc/polynomial.py @@ -106,9 +106,8 @@ class Zernike(Polynomial): """ def __init__(self, coef, radius=1): super().__init__(coef) - r"""Solve order from number of coefficients - N = (order + 1)(order + 2) / 2 - """ + # Solve order from number of coefficients + # N = (order + 1)(order + 2) / 2 self._order = int((math.sqrt(8 * len(self.coef) + 1) - 3) / 2) self.radius = radius norm_vec = np.ones(len(self.coef)) diff --git a/tests/unit_tests/test_polynomials.py b/tests/unit_tests/test_polynomials.py index 414670a289..03f1fd5a46 100644 --- a/tests/unit_tests/test_polynomials.py +++ b/tests/unit_tests/test_polynomials.py @@ -52,7 +52,7 @@ def test_zernike(): assert zn_azimuthal.order == 2 assert zn_azimuthal.radius == 1 - coeff = np.asarray([1.5, -3.6, 9.7e-1, -6.8e-1, 0.11, 0.33e2, 0.002, 13.75, \ + coeff = np.asarray([1.5, -3.6, 9.7e-1, -6.8e-1, 0.11, 0.33e2, 0.002, 13.75, 3.1, -7.3, 7.8e-1, -1.1e-1, 2.56, 5.25e3, 0.123]) zn_azimuthal = openmc.Zernike(coeff, 0.392) assert zn_azimuthal.order == 4