From 32da4f2504967c985f074cfe430e4a56fac2b995 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Mon, 21 Mar 2022 14:07:03 -0500 Subject: [PATCH 01/14] remove optimize and debug build options because they are redudant w/ cmake_build_type --- CMakeLists.txt | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 81ef0c9d2..a047cc9a6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -27,12 +27,12 @@ endif() option(openmp "Enable shared-memory parallelism with OpenMP" ON) option(profile "Compile with profiling flags" OFF) -option(debug "Compile with debug flags" OFF) -option(optimize "Turn on all compiler optimization flags" OFF) option(coverage "Compile with coverage analysis flags" OFF) option(dagmc "Enable support for DAGMC (CAD) geometry" OFF) option(libmesh "Enable support for libMesh unstructured mesh tallies" OFF) +message(STATUS "Build type: ${CMAKE_BUILD_TYPE}") + #=============================================================================== # MPI for distributed-memory parallelism #=============================================================================== @@ -134,18 +134,13 @@ endif() set(CMAKE_POSITION_INDEPENDENT_CODE ON) -list(APPEND cxxflags -O2) -if(debug) - list(REMOVE_ITEM cxxflags -O2) - list(APPEND cxxflags -g -O0) +if (NOT ${CMAKE_BUILD_TYPE}) + add_compile_options(-O2) endif() + if(profile) list(APPEND cxxflags -g -fno-omit-frame-pointer) endif() -if(optimize) - list(REMOVE_ITEM cxxflags -O2) - list(APPEND cxxflags -O3) -endif() if(coverage) list(APPEND cxxflags --coverage) list(APPEND ldflags --coverage) From fcf25b5aba599c372eeeeb44570ddbdd017f63e2 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Mon, 21 Mar 2022 15:39:31 -0500 Subject: [PATCH 02/14] set default build configuration to release --- CMakeLists.txt | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a047cc9a6..27a8f06ad 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -31,7 +31,13 @@ option(coverage "Compile with coverage analysis flags" OFF) option(dagmc "Enable support for DAGMC (CAD) geometry" OFF) option(libmesh "Enable support for libMesh unstructured mesh tallies" OFF) -message(STATUS "Build type: ${CMAKE_BUILD_TYPE}") +#=============================================================================== +# Set build configuration to Release if not set +#=============================================================================== + +if (NOT CMAKE_BUILD_TYPE) + set(CMAKE_BUILD_TYPE Release) +endif() #=============================================================================== # MPI for distributed-memory parallelism @@ -134,10 +140,6 @@ endif() set(CMAKE_POSITION_INDEPENDENT_CODE ON) -if (NOT ${CMAKE_BUILD_TYPE}) - add_compile_options(-O2) -endif() - if(profile) list(APPEND cxxflags -g -fno-omit-frame-pointer) endif() From 0655e7392960758efa2791c80a245620b4590bb1 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Mon, 21 Mar 2022 15:51:19 -0500 Subject: [PATCH 03/14] removed debug and optimize options from install docs --- docs/source/usersguide/install.rst | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/docs/source/usersguide/install.rst b/docs/source/usersguide/install.rst index fb721c7ce..ebcd20eb4 100644 --- a/docs/source/usersguide/install.rst +++ b/docs/source/usersguide/install.rst @@ -331,17 +331,9 @@ CMakeLists.txt Options The following options are available in the CMakeLists.txt file: -debug - Enables debugging when compiling. The flags added are dependent on which - compiler is used. - profile Enables profiling using the GNU profiler, gprof. -optimize - Enables high-optimization using compiler-dependent flags. For gcc and - Intel C++, this compiles with -O3. - openmp Enables shared-memory parallelism using the OpenMP API. The C++ compiler being used must support OpenMP. (Default: on) @@ -360,12 +352,12 @@ coverage Compile and link code instrumented for coverage analysis. This is typically used in conjunction with gcov_. -To set any of these options (e.g. turning on debug mode), the following form +To set any of these options (e.g. turning on profiling), the following form should be used: .. code-block:: sh - cmake -Ddebug=on /path/to/openmc + cmake -Dprofile=on /path/to/openmc .. _gcov: https://gcc.gnu.org/onlinedocs/gcc/Gcov.html From 733604216a161061cd6c7a13e16f2476b6f6e21f Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Mon, 21 Mar 2022 15:53:53 -0500 Subject: [PATCH 04/14] removed optimize and debug from dockerfile --- Dockerfile | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Dockerfile b/Dockerfile index 367777b6e..dc7d25f6c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -179,8 +179,6 @@ RUN mkdir -p ${HOME}/OpenMC && cd ${HOME}/OpenMC \ && mkdir build && cd build ; \ if [ ${build_dagmc} = "on" ] && [ ${build_libmesh} = "on" ]; then \ cmake ../openmc \ - -Doptimize=off \ - -Ddebug=off \ -DHDF5_PREFER_PARALLEL=on \ -Ddagmc=on \ -Dlibmesh=on \ @@ -188,24 +186,18 @@ RUN mkdir -p ${HOME}/OpenMC && cd ${HOME}/OpenMC \ fi ; \ if [ ${build_dagmc} = "on" ] && [ ${build_libmesh} = "off" ]; then \ cmake ../openmc \ - -Doptimize=off \ - -Ddebug=off \ -DHDF5_PREFER_PARALLEL=on \ -Ddagmc=ON \ -DCMAKE_PREFIX_PATH=${DAGMC_INSTALL_DIR} ; \ fi ; \ if [ ${build_dagmc} = "off" ] && [ ${build_libmesh} = "on" ]; then \ cmake ../openmc \ - -Doptimize=off \ - -Ddebug=off \ -DHDF5_PREFER_PARALLEL=on \ -Dlibmesh=on \ -DCMAKE_PREFIX_PATH=${LIBMESH_INSTALL_DIR} ; \ fi ; \ if [ ${build_dagmc} = "off" ] && [ ${build_libmesh} = "off" ]; then \ cmake ../openmc \ - -Doptimize=off \ - -Ddebug=off \ -DHDF5_PREFER_PARALLEL=on ; \ fi ; \ make 2>/dev/null -j${compile_cores} install \ From 643749a0a0c33addbc92bf12db41d09d4a4775e0 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Mon, 21 Mar 2022 15:56:27 -0500 Subject: [PATCH 05/14] specify debug with cmake_build_type --- tools/ci/gha-install.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ci/gha-install.py b/tools/ci/gha-install.py index 9c163c1dc..f22a74410 100644 --- a/tools/ci/gha-install.py +++ b/tools/ci/gha-install.py @@ -26,7 +26,7 @@ def install(omp=False, mpi=False, phdf5=False, dagmc=False, libmesh=False): os.chdir('build') # Build in debug mode by default - cmake_cmd = ['cmake', '-Ddebug=on'] + cmake_cmd = ['cmake', '-DCMAKE_BUILD_TYPE=Debug'] # Turn off OpenMP if specified if not omp: From 97bec2838031cf874a5f1fa6175c922dd0384b8b Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Tue, 22 Mar 2022 10:02:04 -0500 Subject: [PATCH 06/14] set default build with cache variable Co-authored-by: Paul Romano --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 27a8f06ad..6a0066dc6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -36,7 +36,7 @@ option(libmesh "Enable support for libMesh unstructured mesh tallies" OFF) #=============================================================================== if (NOT CMAKE_BUILD_TYPE) - set(CMAKE_BUILD_TYPE Release) + set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "Choose the type of build" FORCE) endif() #=============================================================================== From d24c1805927254d7964f614c48f8bdb182da7bc3 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Tue, 22 Mar 2022 10:46:34 -0500 Subject: [PATCH 07/14] update scripts with new cmake flag names --- CMakeLists.txt | 24 ++++++++++++------------ Dockerfile | 8 ++++---- tools/ci/gha-install.py | 8 ++++---- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 6a0066dc6..168309de8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -25,11 +25,11 @@ endif() # Command line options #=============================================================================== -option(openmp "Enable shared-memory parallelism with OpenMP" ON) -option(profile "Compile with profiling flags" OFF) -option(coverage "Compile with coverage analysis flags" OFF) -option(dagmc "Enable support for DAGMC (CAD) geometry" OFF) -option(libmesh "Enable support for libMesh unstructured mesh tallies" OFF) +option(OPENMC_ENABLE_PROFILE "Enable shared-memory parallelism with OpenMP" ON) +option(OPENMC_ENABLE_COVERAGE "Compile with profiling flags" OFF) +option(OPENMC_USE_OPENMP "Compile with coverage analysis flags" OFF) +option(OPENMC_USE_DAGMC "Enable support for DAGMC (CAD) geometry" OFF) +option(OPENMC_USE_LIBMESH "Enable support for libMesh unstructured mesh tallies" OFF) #=============================================================================== # Set build configuration to Release if not set @@ -66,7 +66,7 @@ endmacro() # DAGMC Geometry Support - need DAGMC/MOAB #=============================================================================== -if(dagmc) +if(OPENMC_USE_DAGMC) find_package(DAGMC REQUIRED PATH_SUFFIXES lib/cmake) if (${DAGMC_VERSION} VERSION_LESS 3.2.0) message(FATAL_ERROR "Discovered DAGMC Version: ${DAGMC_VERSION}. \ @@ -78,7 +78,7 @@ endif() # libMesh Unstructured Mesh Support #=============================================================================== -if(libmesh) +if(OPENMC_USE_LIBMESH) find_package(LIBMESH REQUIRED) endif() @@ -129,7 +129,7 @@ endif() # Skip for Visual Studio which has its own configurations through GUI if(NOT MSVC) -if(openmp) +if(OPENMC_USE_OPENMP) find_package(OpenMP) if(OPENMP_FOUND) # In CMake 3.9+, can use the OpenMP::OpenMP_CXX imported target @@ -140,10 +140,10 @@ endif() set(CMAKE_POSITION_INDEPENDENT_CODE ON) -if(profile) +if(OPENMC_ENABLE_PROFILE) list(APPEND cxxflags -g -fno-omit-frame-pointer) endif() -if(coverage) +if(OPENMC_ENABLE_COVERAGE) list(APPEND cxxflags --coverage) list(APPEND ldflags --coverage) endif() @@ -433,12 +433,12 @@ else() target_link_libraries(libopenmc pugixml) endif() -if(dagmc) +if(OPENMC_USE_DAGMC) target_compile_definitions(libopenmc PRIVATE DAGMC) target_link_libraries(libopenmc dagmc-shared uwuw-shared) endif() -if(libmesh) +if(OPENMC_USE_LIBMESH) target_compile_definitions(libopenmc PRIVATE LIBMESH) target_link_libraries(libopenmc PkgConfig::LIBMESH) endif() diff --git a/Dockerfile b/Dockerfile index dc7d25f6c..6a9b89009 100644 --- a/Dockerfile +++ b/Dockerfile @@ -180,20 +180,20 @@ RUN mkdir -p ${HOME}/OpenMC && cd ${HOME}/OpenMC \ if [ ${build_dagmc} = "on" ] && [ ${build_libmesh} = "on" ]; then \ cmake ../openmc \ -DHDF5_PREFER_PARALLEL=on \ - -Ddagmc=on \ - -Dlibmesh=on \ + -DOPENMC_USE_DAGMC=on \ + -DOPENMC_USE_LIBMESH=on \ -DCMAKE_PREFIX_PATH="${DAGMC_INSTALL_DIR};${LIBMESH_INSTALL_DIR}" ; \ fi ; \ if [ ${build_dagmc} = "on" ] && [ ${build_libmesh} = "off" ]; then \ cmake ../openmc \ -DHDF5_PREFER_PARALLEL=on \ - -Ddagmc=ON \ + -DOPENMC_USE_DAGMC=ON \ -DCMAKE_PREFIX_PATH=${DAGMC_INSTALL_DIR} ; \ fi ; \ if [ ${build_dagmc} = "off" ] && [ ${build_libmesh} = "on" ]; then \ cmake ../openmc \ -DHDF5_PREFER_PARALLEL=on \ - -Dlibmesh=on \ + -DOPENMC_USE_LIBMESH=on \ -DCMAKE_PREFIX_PATH=${LIBMESH_INSTALL_DIR} ; \ fi ; \ if [ ${build_dagmc} = "off" ] && [ ${build_libmesh} = "off" ]; then \ diff --git a/tools/ci/gha-install.py b/tools/ci/gha-install.py index f22a74410..4cc85671d 100644 --- a/tools/ci/gha-install.py +++ b/tools/ci/gha-install.py @@ -30,7 +30,7 @@ def install(omp=False, mpi=False, phdf5=False, dagmc=False, libmesh=False): # Turn off OpenMP if specified if not omp: - cmake_cmd.append('-Dopenmp=off') + cmake_cmd.append('-DOPENMC_USE_OPENMP=off') # Use MPI wrappers when building in parallel if mpi: @@ -46,16 +46,16 @@ def install(omp=False, mpi=False, phdf5=False, dagmc=False, libmesh=False): cmake_cmd.append('-DHDF5_PREFER_PARALLEL=OFF') if dagmc: - cmake_cmd.append('-Ddagmc=ON') + cmake_cmd.append('-DOPENMC_USE_DAGMC=ON') cmake_cmd.append('-DCMAKE_PREFIX_PATH=~/DAGMC') if libmesh: - cmake_cmd.append('-Dlibmesh=ON') + cmake_cmd.append('-DOPENMC_USE_LIBMESH=ON') libmesh_path = os.environ.get('HOME') + '/LIBMESH' cmake_cmd.append('-DCMAKE_PREFIX_PATH=' + libmesh_path) # Build in coverage mode for coverage testing - cmake_cmd.append('-Dcoverage=on') + cmake_cmd.append('-DOPENMC_ENABLE_COVERAGE=on') # Build and install cmake_cmd.append('..') From 61ace1ab09ef6d1a2186dda663416c9699aa86b2 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Tue, 22 Mar 2022 10:50:58 -0500 Subject: [PATCH 08/14] update documentation with new options names --- docs/source/usersguide/install.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/source/usersguide/install.rst b/docs/source/usersguide/install.rst index ebcd20eb4..7aa1fdcff 100644 --- a/docs/source/usersguide/install.rst +++ b/docs/source/usersguide/install.rst @@ -331,33 +331,33 @@ CMakeLists.txt Options The following options are available in the CMakeLists.txt file: -profile - Enables profiling using the GNU profiler, gprof. +OPENMC_ENABLE_PROFILE + Enables profiling using the GNU profiler, gprof. (Default: off) -openmp +OPENMC_USE_OPENMP Enables shared-memory parallelism using the OpenMP API. The C++ compiler being used must support OpenMP. (Default: on) -dagmc +OPENMC_USE_DAGMC Enables use of CAD-based DAGMC_ geometries and MOAB_ unstructured mesh tallies. Please see the note about DAGMC in the optional dependencies list for more information on this feature. The installation directory for DAGMC should also be defined as `DAGMC_ROOT` in the CMake configuration command. (Default: off) -libmesh +OPENMC_USE_LIBMESH Enables the use of unstructured mesh tallies with libMesh_. (Default: off) -coverage +OPENMC_ENABLE_COVERAGE Compile and link code instrumented for coverage analysis. This is typically - used in conjunction with gcov_. + used in conjunction with gcov_. (Default: off) To set any of these options (e.g. turning on profiling), the following form should be used: .. code-block:: sh - cmake -Dprofile=on /path/to/openmc + cmake -DOPENMC_ENABLE_PROFILE=on /path/to/openmc .. _gcov: https://gcc.gnu.org/onlinedocs/gcc/Gcov.html From d118617e292762989a0960f4b0a6cef4dd28d6d2 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Tue, 22 Mar 2022 11:09:25 -0500 Subject: [PATCH 09/14] added section on build types to install doc --- docs/source/usersguide/install.rst | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/docs/source/usersguide/install.rst b/docs/source/usersguide/install.rst index 7aa1fdcff..d5b1c7e41 100644 --- a/docs/source/usersguide/install.rst +++ b/docs/source/usersguide/install.rst @@ -363,6 +363,27 @@ should be used: .. _usersguide_compile_mpi: +Specifying the Build Type ++++++++++++++++++++++++++ + +OpenMC can be configured for debug, release, or release with debug info by setting +the `CMAKE_BUILD_TYPE` option. + +Debug + Enable debug compiler flags with no optimization `-O0 -g`. + +Release + Disable debug and enable optimization `-O3 -DNDEBUG`. + +RelWithDebInfo + (Default if no type is specified.) Enable optimization and debug `-O2 -g`. + +Example of configuring for Debug mode: + +.. code-block:: sh + + cmake -DCMAKE_BUILD_TYPE=Debug /path/to/openmc + Compiling with MPI ++++++++++++++++++ From 62bb9ebf990bf1062d6cf8f9137f535a1cbb0c44 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Tue, 22 Mar 2022 13:23:02 -0500 Subject: [PATCH 10/14] corrected install options in cmake config --- cmake/OpenMCConfig.cmake.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/OpenMCConfig.cmake.in b/cmake/OpenMCConfig.cmake.in index b12e95f23..8f7ae7193 100644 --- a/cmake/OpenMCConfig.cmake.in +++ b/cmake/OpenMCConfig.cmake.in @@ -5,11 +5,11 @@ find_package(gsl-lite REQUIRED HINTS ${OpenMC_CMAKE_DIR}/../gsl-lite) find_package(pugixml REQUIRED HINTS ${OpenMC_CMAKE_DIR}/../pugixml) find_package(xtl REQUIRED HINTS ${OpenMC_CMAKE_DIR}/../xtl) find_package(xtensor REQUIRED HINTS ${OpenMC_CMAKE_DIR}/../xtensor) -if(@dagmc@) +if(@OPENMC_USE_DAGMC@) find_package(DAGMC REQUIRED HINTS @DAGMC_DIR@) endif() -if(@libmesh@) +if(@OPENMC_USE_LIBMESH@) include(FindPkgConfig) list(APPEND CMAKE_PREFIX_PATH @LIBMESH_PREFIX@) set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH True) From 0e79264e7fb9e4e1b0c9fafb7b531c734cd2d493 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Tue, 22 Mar 2022 13:27:40 -0500 Subject: [PATCH 11/14] corrected install docs with new dagmc and libmess flags --- docs/source/usersguide/install.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/source/usersguide/install.rst b/docs/source/usersguide/install.rst index d5b1c7e41..dcf55948c 100644 --- a/docs/source/usersguide/install.rst +++ b/docs/source/usersguide/install.rst @@ -252,7 +252,7 @@ Prerequisites In addition to turning this option on, the path to the DAGMC installation should be specified as part of the ``CMAKE_PREFIX_PATH`` variable:: - cmake -Ddagmc=on -DCMAKE_PREFIX_PATH=/path/to/dagmc/installation + cmake -DOPENMC_USE_DAGMC=on -DCMAKE_PREFIX_PATH=/path/to/dagmc/installation * libMesh_ mesh library framework for numerical simulations of partial differential equations @@ -263,7 +263,7 @@ Prerequisites installation should be specified as part of the ``CMAKE_PREFIX_PATH`` variable.:: - CXX=mpicxx cmake -Dlibmesh=on -DCMAKE_PREFIX_PATH=/path/to/libmesh/installation + CXX=mpicxx cmake -DOPENMC_USE_LIBMESH=on -DCMAKE_PREFIX_PATH=/path/to/libmesh/installation Note that libMesh is most commonly compiled with MPI support. If that is the case, then OpenMC should be compiled with MPI support as well. From 3f2d85cad331f3db38cef5479b839dc3f5534f03 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Tue, 22 Mar 2022 14:34:26 -0500 Subject: [PATCH 12/14] fix order --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 168309de8..772256f84 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -25,9 +25,9 @@ endif() # Command line options #=============================================================================== -option(OPENMC_ENABLE_PROFILE "Enable shared-memory parallelism with OpenMP" ON) -option(OPENMC_ENABLE_COVERAGE "Compile with profiling flags" OFF) -option(OPENMC_USE_OPENMP "Compile with coverage analysis flags" OFF) +option(OPENMC_USE_OPENMP "Enable shared-memory parallelism with OpenMP" ON) +option(OPENMC_ENABLE_PROFILE "Compile with profiling flags" OFF) +option(OPENMC_ENABLE_COVERAGE "Compile with coverage analysis flags" OFF) option(OPENMC_USE_DAGMC "Enable support for DAGMC (CAD) geometry" OFF) option(OPENMC_USE_LIBMESH "Enable support for libMesh unstructured mesh tallies" OFF) From 4f93bf22f566dbfab9cb2713681d57d411c9e31b Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Wed, 23 Mar 2022 09:53:50 -0500 Subject: [PATCH 13/14] Apply suggestions from code review Co-authored-by: Paul Romano --- CMakeLists.txt | 3 ++- docs/source/usersguide/install.rst | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 772256f84..bc9e12c91 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -35,7 +35,8 @@ option(OPENMC_USE_LIBMESH "Enable support for libMesh unstructured mesh tall # Set build configuration to Release if not set #=============================================================================== -if (NOT CMAKE_BUILD_TYPE) +if(NOT CMAKE_BUILD_TYPE) + message(STATUS "No build type selected, defaulting to RelWithDebInfo") set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "Choose the type of build" FORCE) endif() diff --git a/docs/source/usersguide/install.rst b/docs/source/usersguide/install.rst index dcf55948c..42258b086 100644 --- a/docs/source/usersguide/install.rst +++ b/docs/source/usersguide/install.rst @@ -352,7 +352,7 @@ OPENMC_ENABLE_COVERAGE Compile and link code instrumented for coverage analysis. This is typically used in conjunction with gcov_. (Default: off) -To set any of these options (e.g. turning on profiling), the following form +To set any of these options (e.g., turning on profiling), the following form should be used: .. code-block:: sh From 094330ef12a2ff3a3d781204957d3400966a4081 Mon Sep 17 00:00:00 2001 From: Kalin Kiesling Date: Wed, 23 Mar 2022 10:49:42 -0500 Subject: [PATCH 14/14] code review suggestions Co-authored-by: Paul Romano --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index bc9e12c91..ba8a79efa 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -32,7 +32,7 @@ option(OPENMC_USE_DAGMC "Enable support for DAGMC (CAD) geometry" option(OPENMC_USE_LIBMESH "Enable support for libMesh unstructured mesh tallies" OFF) #=============================================================================== -# Set build configuration to Release if not set +# Set a default build configuration if not explicitly specified #=============================================================================== if(NOT CMAKE_BUILD_TYPE)