Commit graph

600 commits

Author SHA1 Message Date
Paul Romano
bc09d1ef55 adding back files to be reviewed 2019-10-28 11:55:45 -05:00
Paul Romano
ae28233110 deleting all files to prepare for review 2019-10-28 11:48:19 -05:00
Paul Romano
e07fe06323 Remove -dev tag from version number. Small updates to release notes 2019-10-07 10:33:45 -05:00
Paul Romano
ae1209e283
Merge pull request #1367 from pshriwise/initialize_mat_id
Correction to `id_` attribute in Material/Filter classes
2019-10-01 08:26:24 -05:00
Paul Romano
db8cdff1c5
Merge pull request #1357 from drewejohnson/internal-tally
Create and use internal tallies for depletion
2019-10-01 08:26:12 -05:00
Andrew Johnson
484bf70c86
Tally.get_writable() -> Tally.writable()
Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2019-09-30 18:55:42 -04:00
Patrick Shriwise
e7b28ab8d9 Removing default values for set_id args as requested by @paulromano. 2019-09-30 14:31:26 -05:00
Patrick Shriwise
1b8bc2d01d Correcting default values in set_id methods. Initializing material ids to match the initialization logic. 2019-09-27 10:43:36 -05:00
Andrew Johnson
801f18b357
Provide Tally writable_ setter and getters
New member functions openmc::Tally.set_writable and get_writable
act on the writable attribute. These are used in the external
API with openmc_tally_set_writable and openmc_tally_get_writable
functions.

Cleaned up some other writeable -> writable typos as well
2019-09-26 21:09:13 -04:00
Andrew Johnson
7a1a424d0f
Tally.writeable -> Tally.writable
Oops

Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2019-09-26 20:34:11 -04:00
Andrew Johnson
66593fd7e1
Expose tally.writeable_ through openmc.lib
Add two functions to capi.h:
openmc_tally_set_writeable and openmc_tally_get_writeable
which are exposed to the Python API through the
openmc.lib.Tally.writeable property. These functions are very
similar to the set/get active counterparts as both act on a boolean
Tally attribute

A new unit test test_tally_writeable has been added that toggles
the writeable state of a tally. It is important to note that the
writeable state must be reset, otherwise tallies in subsequent
tests will be skewed. This is because the test_tally_writeable
function requires the capi_simulation_init fixture and the tallies
are shared by those functions that use the capi_run fixture
2019-09-20 10:13:26 -05:00
Andrew Johnson
e17687d457
Add openmc::Tally.writeable_ attribute
Boolean flag that indicates if a tally should be written to
output files. This has no effect on tally scoring, but instead
will be used to skip writing Tally data for those not marked
as writeable.

Related to #1327 as the depletion interface will use this flag
to reduce time spent writing reaction rate tallies and also
reducing the size of the final statepoint files
2019-09-19 09:18:26 -05:00
Paul Romano
30efbcc6a8 Add a missing virtual destructor on Mesh 2019-09-18 13:37:04 -05:00
rockfool
bfba0e6b1b Merge remote-tracking branch 'upstream/develop' into white 2019-09-17 11:30:58 -04:00
Patrick Shriwise
c0e32b751b Addressing comments from @paulromano. 2019-09-16 23:48:52 -05:00
Patrick Shriwise
8ebfdc3eb7 Improving documentation. 2019-09-16 15:45:54 -05:00
Patrick Shriwise
962f3d46f1 Adding documentation for some of these new methods. 2019-09-16 15:45:54 -05:00
Patrick Shriwise
36fb89dead Making analagous function for finding the right parenthesis. 2019-09-16 15:45:54 -05:00
Patrick Shriwise
25df513a77 Renaming function. 2019-09-16 15:45:54 -05:00
Patrick Shriwise
3dfc2da2a5 Removing unused bounding box method. 2019-09-16 15:45:54 -05:00
Patrick Shriwise
789d55a35a Removing complement operator in a separate step. 2019-09-16 15:45:54 -05:00
Patrick Shriwise
0d02f8b2d2 Working now. Needs cleanup. 2019-09-16 15:45:54 -05:00
Patrick Shriwise
85fa32150a Still needs work 2019-09-16 15:45:53 -05:00
Patrick Shriwise
0f730d213e Added is_valid method to BoundingBox. 2019-09-16 15:45:53 -05:00
rockfool
fbaa780731 remove the surface.py first 2019-09-16 14:03:05 -04:00
Paul Romano
85f80f6b33 Make sure Nuclide::reaction_index_ is big enough for MT=901 2019-09-16 10:59:03 -05:00
Paul Romano
d84c379007 Fix up heating tally scores 2019-09-13 09:31:08 -05:00
rockfool
5f394b2816 add white boundary condition 2019-09-09 16:22:25 -04:00
Paul Romano
d572379399 Fix reading of Debye-Waller for incoherent elastic 2019-09-06 16:26:44 -05:00
Amanda Lund
7fd8288141
Merge pull request #1306 from paulromano/set-temp-check
Add temperature check when setting cell temperatures
2019-08-08 17:53:37 -05:00
Andrew Johnson
9b7ab0bacb
Expose/improve EnergyFunctionFilter through C-API
Add three functions that can be used to modify EnergyFunctionFilters
through the C-API:
- openmc_energyfunc_filter_set_data: set energy and y data
- openmc_energyfunc_filter_get_energy: obtain energies used in
interpolation
- openmc_energyfunc_filter_get_y: obtain ordinate values
These functions are modeled after openmc_energy_filter_[get|set]_bins.

The set_data function relies upon the new
EnergyFunctionFilter::set_data function, which is analogous
to EnergyFilter::set_bins function. Checks are performed
to make sure the energy and ordinate vectors are of equal
size before resetting and populating energy and y
private members.

An EnergyFunctionFilter did exist in openmc.capi, and has
now been flushed out to provide a better __init__ method,
as well as properties for retrieving energies and ordinates
for interpolation.
2019-07-30 11:49:21 -05:00
Paul Romano
d7bcf60eb4 Store min/max data temperatures. Use in Cell::set_temperature to check bounds 2019-07-30 10:18:17 -05:00
Patrick Shriwise
5ad4f94f3a Removing CAPI function for bounding box of any type. Moving to a cell-only function. Tests are adjusted as needed. 2019-07-24 13:10:03 -05:00
Patrick Shriwise
3439797e32 Update for case where the entire region is a complement. Addition of a cell and redefinition of another to test more robustly. 2019-07-24 03:02:10 -05:00
Patrick Shriwise
d820e6777a
Apply suggestions from code review
Accessing cell/material names through accessor. Returning a const reference from `name()` accessor in both cases.

Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2019-07-23 14:33:35 -05:00
Patrick Shriwise
c1ca3028cb A few more small updates. 2019-07-18 22:43:21 -05:00
Patrick Shriwise
933a5c4770 Updates based on suggestions from @paulromano. 2019-07-18 22:21:55 -05:00
Patrick Shriwise
72e92e9ad0 More updates. Adding complex cell test to unit tests. 2019-07-18 18:14:57 -05:00
Patrick Shriwise
81bf0a67da Implementing intersection and union operators for BoundingBox. 2019-07-18 13:54:24 -05:00
Patrick Shriwise
6d97188413 Creating a default virtual definition for a surfce bounding box and removing redundant definitions of surfaces with unbounded boxes. 2019-07-18 12:57:23 -05:00
Patrick Shriwise
54df651888 Adding Material accessors for name. 2019-07-18 12:25:53 -05:00
Patrick Shriwise
df379471dd Adding Cell accessors for name. 2019-07-18 12:19:13 -05:00
Patrick Shriwise
08e78a3215 Removing unecessary forward declaration. 2019-07-16 17:09:44 -05:00
Patrick Shriwise
1d02c87466 Some self-review. 2019-07-16 16:52:30 -05:00
Patrick Shriwise
d223046b30 Adding complement operator back into internal cell RPN. Updating complex_cell bounding box algorithm to parse existing RPN. 2019-07-16 16:52:30 -05:00
Patrick Shriwise
e9ac007367 Removing complement from internal RPN. 2019-07-16 16:52:30 -05:00
Patrick Shriwise
1d075cefdd Adding name property to CAPI cell/material classes. 2019-07-16 16:52:30 -05:00
Patrick Shriwise
a105702455 Updates to CAPI bounding box methods. Addition of global bounding box method. Adding tests for PWR pincell model. 2019-07-16 16:52:30 -05:00
Patrick Shriwise
ecbf7596c0 Corrections to surface bounding boxes based on sign. Corrections to cell/universe bounding boxes and capi exposure. 2019-07-16 16:52:30 -05:00
Patrick Shriwise
08239a98d2 Adding a bounding box method to the universe class. 2019-07-16 16:52:30 -05:00