Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
This modification will eliminate the warning:
/home/valerio/.local/lib/python3.8/site-packages/openmc/surface.py:1510: FutureWarning: "ZCylinder(…) accepts an argument named ‘r’, not ‘R’. Future versions of OpenMC will not accept the capitalized version.
warn(_WARNING_UPPER.format(type(self).name, ‘r’, ‘R’)
Anything that can be filled by a cell can be passed to
openmc.model.pin, including Universes and lattices.
Checks are included for the volume division, as not
all supported items, like Lattice instances, have volume
attributes.
A test was added to check this capability, where a universe
is used as one of the interior elements for the pin.
Various cosmetic changes to address reviewer comments.
Function openmc.model.funcs.pin has replaced the class-based
openmc.model.pin.Pin
Subdivision functionality is maintained by passing a dictionary
of integer ring indexes -> number of divisions to the function
Tests have been updated accordingly and are parametrized
against surface type: X, Y, and Z cylinders
