Ethan Peterson
a25882e76f
more unit tests
2020-02-27 10:27:42 -05:00
Ethan Peterson
7d69ff6de1
applied suggestions from code review
2020-02-27 10:27:42 -05:00
Ethan Peterson
cb92d02537
initial unit tests working
2020-02-27 10:27:42 -05:00
Ethan Peterson
a1f7cb7387
Implementing Surface Rotations
2020-02-27 10:27:42 -05:00
Ethan Peterson
e6cf49275a
applied suggestions from code review
2020-02-25 08:42:21 -05:00
Ethan Peterson
e3af035095
finished unit tests and fixed wrong math
2020-02-25 08:42:21 -05:00
Ethan Peterson
1e5a8e56ff
removed use of round in favor of isclose
2020-02-25 08:42:21 -05:00
Ethan Peterson
3d3a27f841
applied suggestions from code review
2020-02-25 08:42:21 -05:00
Ethan Peterson
378856d434
Apply suggestions from code review
...
Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2020-02-25 08:42:21 -05:00
Ethan Peterson
ac5bb4047d
removed extraneous definition
2020-02-25 08:42:21 -05:00
Ethan Peterson
089b6d04ef
removed __init_subclass__ since it's not in python 3.5
2020-02-25 08:42:21 -05:00
Ethan Peterson
2870da61e6
Refactoring improvements
2020-02-25 08:42:21 -05:00
Ethan Peterson
6c2ef8b7f0
removed coefficient caching
2020-02-19 14:28:56 -05:00
Ethan Peterson
a7bf713732
merged remote into local after review
2020-02-19 10:00:22 -05:00
Ethan Peterson
44d2527faf
applied more suggestions from code review and added coefficient cache for general cones and cylinders
2020-02-19 09:56:46 -05:00
Ethan Peterson
9a21eabd55
Apply suggestions from code review
...
Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2020-02-19 08:46:50 -05:00
Ethan Peterson
2332a679fa
reverted simplifying Plane constructor and default args
2020-02-18 10:08:22 -05:00
Ethan Peterson
35fb12b361
implemented Plane.__new__ for returning simplified versions
2020-02-14 11:37:26 -05:00
Ethan Peterson
33c46c78c8
refactored translate method back out to mixins
2020-02-14 09:55:57 -05:00
Ethan Peterson
38640840c1
applied some suggestions from code review
2020-02-14 09:16:14 -05:00
Ethan Peterson
f1b14c95e2
implemented individual translate and evaulate methods and removed extraneous docstrings
2020-02-13 16:19:14 -05:00
Ethan Peterson
2919b2791a
finished implementation
2020-02-13 16:19:14 -05:00
Ethan Peterson
90d41aeabe
finished general cone transformation
2020-02-13 16:19:14 -05:00
Ethan Peterson
777803c029
implemented helper functions
2020-02-13 16:19:14 -05:00
Ethan Peterson
994bd221ba
fixed general cylinder _to_base_coeffs method
2020-02-13 16:19:14 -05:00
Ethan Peterson
caeb4d3ce5
removed empty dictionary definition
2020-02-13 16:19:14 -05:00
Ethan Peterson
29255732ca
changed subclass finding methods to private
2020-02-13 16:19:14 -05:00
Ethan Peterson
2a1c48e987
refactoring bounding_box and cleaning up constructors
2020-02-13 16:19:14 -05:00
Ethan Peterson
a2f96ffe34
fixed bug in quadric translate function
2020-02-13 16:19:14 -05:00
Ethan Peterson
6b3a231994
fixed issue related to finding all surface subclasses
2020-02-13 16:19:14 -05:00
Ethan Peterson
0ad5dbd446
cleaning up and making code more self-consistent
2020-02-13 16:19:14 -05:00
Ethan Peterson
ab465084b6
still working through coefficient transformations, done with (X,Y,Z)Cylinders and Cones, Planes, Quadric
2020-02-13 16:19:14 -05:00
Ethan Peterson
542643f91a
fixed typos in translate and __init__
2020-02-13 16:19:14 -05:00
Ethan Peterson
9740f91ffc
working out some _get_base_coeff methods
2020-02-13 16:19:14 -05:00
Ethan Peterson
64ee9b177f
finished skeleton framework for refactoring surfaces
2020-02-13 16:19:14 -05:00
Ethan Peterson
5af686b4fb
working on quadric refactoring
2020-02-13 16:19:14 -05:00
Ethan Peterson
6d6988b2c8
refactoring surface classes
2020-02-13 16:19:14 -05:00
Ethan Peterson
55fab15b9a
Implementing duplicate surface detection and removal
...
Co-Authored-By: Andrew Johnson <drewej@protonmail.com>
Co-Authored-By: Patrick Shriwise <pshriwise@gmail.com>
Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2020-01-20 09:45:44 -05:00
rockfool
7bf455d722
add white boundary in surface.py
2019-09-17 12:36:43 -04:00
rockfool
c88f013795
add white in surface.py
2019-09-16 14:23:31 -04:00
rockfool
d0eb84dd4e
fix the conflict in surface.py
2019-09-16 14:12:54 -04:00
rockfool
fbaa780731
remove the surface.py first
2019-09-16 14:03:05 -04:00
rockfool
5f394b2816
add white boundary condition
2019-09-09 16:22:25 -04:00
Paul Romano
d85df13ae7
Make surfaces take coefficients as first arguments
2019-09-04 15:10:53 -05:00
liangjg
ea71b9e377
replace all dataset.value with dataset[()] (or occasionally dataset[...])
2019-03-27 11:45:48 -04:00
Paul Romano
2d13d41da3
Merge pull request #1189 from pshriwise/corner_radius
...
Fix for hexagonal prism convenience function
2019-03-12 06:52:05 -05:00
Patrick Shriwise
e1aa836ea6
Adding some point checks for the hex prism test and removing import from surfae.py.
2019-03-08 14:45:33 -06:00
Paul Romano
325f9fcf72
Use lower-case argument names for surfaces consistently
2019-03-08 11:25:26 -06:00
Paul Romano
394ac75560
Add translate methods to surfaces and regions
2019-03-06 15:38:26 -06:00
Paul Romano
2943e38a81
Add Plane.from_points and cylinder_from_points convenience functions
2019-03-06 15:38:22 -06:00