Commit graph

643 commits

Author SHA1 Message Date
Patrick Shriwise
0785500bc4
Updating file extension for Excel files when exporting MGXS data (#2852) 2024-01-19 21:32:43 +00:00
Paul Romano
94f02ae10b
Bump version to 0.14.0-dev (#2740) 2023-10-31 16:55:19 -05:00
Jonathan Shimwell
9b7b33c7fa
Ruff comments on code (#2696)
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2023-09-26 03:37:19 +00:00
Jonathan Shimwell
457bea6f0b
replaced ordereddict with {} (#2641)
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2023-08-19 12:15:11 +00:00
bscollin
cd13d3471d
Adds MPACT library group structures and documentation to mgxs collection (#2614) 2023-07-25 16:13:00 -05:00
Jonathan Shimwell
ee7b95245a
Static errors continuation (#2557)
Co-authored-by: Christina Cai <chrsitinacai48933@gmail.com>
Co-authored-by: christinacai123 <63215816+christinacai123@users.noreply.github.com>
2023-06-16 22:34:02 -05:00
Paul Romano
39bc94a1a1 Allow mgxs.EnergyGroups() to accept group structure name 2023-04-11 13:23:13 -05:00
guyshtot
00657ccf87
Update openmc/mgxs/library.py
apply CR suggestion

Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2023-03-25 13:50:06 +03:00
guyshtot
a704ec73f2 Applied CR suggestion 2023-03-23 13:12:36 +02:00
guyshtot
354fd34c2c Renamed previous use of _nuclides to _atomic_weight_ratios in the library class 2023-03-21 14:59:01 +02:00
guyshtot
487f02dd1d Add option to specify nuclides in the Library class 2023-03-21 13:18:24 +02:00
Paul Romano
990b5449f5 Avoid use of np.float and np.int 2023-02-10 11:41:49 -06:00
Paul Romano
a5bdbd3adb Address a few warnings from tests 2022-12-23 00:07:02 -06:00
Adam Nelson
11f8d6eb29
Merge pull request #1916 from mkreher13/diffusion-condense
Condensing diffusion instead of transport
2022-09-20 09:00:19 -05:00
Miriam Kreher
985b2d2696 Removed the option to condense transport cross sections instead of diffusion coefficients. 2022-08-26 21:07:15 -04:00
Paul Romano
48fb58a05d
Merge pull request #2174 from paulromano/prepare-0.13.1
Prepare for version 0.13.1
2022-08-18 06:54:40 -05:00
Jonathan Shimwell
9b458c102a
Review suggestions from @paulromano
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2022-08-17 07:28:50 +01:00
Paul Romano
d31b083685 Address @yardasol review comments 2022-08-16 16:19:55 -05:00
Jonathan Shimwell
6c592fa1a0 renamed 2000 to 1968 2022-08-16 16:59:12 +01:00
Jonathan Shimwell
d0963a0a8a renamed group name to match serpent reference 2022-08-16 16:52:23 +01:00
Jonathan Shimwell
762993fb8b added "ecco-2000" with 1968 bins 2022-08-16 16:47:08 +01:00
Paul Romano
18bf88bab0 Fix typos in mgxs.py spotted by @mkreher13 2022-08-08 10:23:42 -05:00
Paul Romano
54ac2042fb Add ReducedAbsorptionXS class for MGXS (absorption - n2n - 2*n3n - 3*n4n) 2022-08-03 15:58:54 -05:00
Paul Romano
b32d121e22 Use add_params decorator to cut down on repeated docstrings for MGXS classes 2022-08-03 14:34:58 -05:00
Paul Romano
0c04053242
Merge pull request #2046 from nelsonag/mgxs_print_xs_issue2042
Clarify usage of MGXS.rxn_type in MGXS.print_xs methods
2022-05-09 14:13:22 -05:00
Adam Nelson
21930fa795 Removing hdf5_key, and thus not keeping it as a deprecated interface to mgxs_type 2022-05-09 10:22:28 -05:00
Adam Nelson
baf35e74ca Resolved versionadded/deprecated versions per @paulromano comments and fixed failing test: missed one legacy _hdf5_key in DelayedNuFissionMatrixXS! I guess that shows the new parameter works, so, yeah, totally on purpose 2022-05-06 06:29:27 -05:00
Paul Romano
45a6b31c8f Change StatePoint.k_combined -> keff, ResultsList.get_eigenvalue -> get_keff 2022-05-02 12:09:43 -05:00
shimwell
94c282670c removed typo in group name 2022-04-28 15:13:12 +01:00
Adam Nelson
deae584408 Renaming MGXS.hdf5_key to MGXS.mgxs_type and adding a deprecation warning for MGXS.hdf5_key by using a property which gives the warning then uses MGXS.mgxs_type 2022-04-27 12:58:41 -05:00
Adam Nelson
41e18a0893 Making MGXS.print_xs (and inheriting classes) use hdf5_key for the printed reaction type when using print_xs as that is more descriptive 2022-04-27 12:29:09 -05:00
shimwell
252ddc17b0 trailing comma and lower bound fixes 2022-04-27 17:30:38 +01:00
shimwell
e5016ac963 added scale 44 group structure 2022-04-27 15:48:07 +01:00
Paul Romano
696290f051 Update nuclide naming in documentation 2022-02-22 16:45:12 -06:00
Miriam Rathbun
672bb9e431 I believe I successfully implemented condensation of diffusion coefficients (as opposed to transport cross sections). 2021-11-22 22:46:40 -07:00
Miriam Rathbun
e131e07948 Fixed issue where both P0 and P1 moments were displayed in the diffusion coefficient results. With this fix, the Legendre filter is successfully sliced. Also, there was previously concern that get_condensed_xs needed to be specially catered toward DiffusionCoefficient. However, since the MGXS get_condensed_xs method condenses the tallies before calculating the cross section, that should work great for DiffusionCoefficient as well. Tests updated. 2021-11-16 13:58:40 -07:00
Paul Romano
28b37011b0 Add release notes for 0.12.1 and a bunch of versionadded tags 2021-03-17 07:33:57 -05:00
Jonathan Shimwell
9711db7e2e added vit-j-42 to docstring 2021-03-04 10:26:26 +00:00
Jonathan Shimwell
3614246d01 added VITAMIN-J-42 to group structures 2021-03-03 19:01:41 +00:00
Miriam
e4b14d2ac6 Quick fix related to the shape of decay-rate. 2021-01-14 17:59:26 +00:00
Adam Nelson
7505718806
Merge pull request #1718 from mkreher13/transient-rewrite
Fixed several bugs related to decay-rate
2020-12-11 10:26:42 -06:00
agnelson
a9ebadaecc Fixing comments per the review by @paulromano 2020-11-09 15:59:23 -06:00
Miriam
954450a841 Fixed several bugs related to decay-rate
1) In mdgxs.py, DecayRate, get_xs(). There is no need to reverse the order
since there isn't an energy group filter anymore. Also, the new_shape
addition formats the cross section like all the others. I updated
mgxs_library_hdf5 test results accordingly.

2) In material.cpp. If you use a macroscopic dnesity other than 1.0,
the code still pushed back '1.0'. My change fixes that. Using a macro
density other than 1.0 wasn't tested anywhere, so I modifed mg_convert
to take a density of 1.1. The default macro density of 1.0 is used in
many other tests.

3) tally_scoring.cpp. Notice that the score is accumulated, then sent
to the function score_fission_delayed_dg where the tally is accumulated.
This amounts to "double accumulation". It makes sense to accumulate the score
over the delayed groups if there is no delayed group filter, but in this
case, when delayed group filter is not None, the score needs to reset
each time.

In other parts of SCORE_DECAY_RATE, I think the distinction between
accumulating and resetting the score is correct. The only place I wasn't
sure was line 1057 (and its equivalent in multi-group, line 1962).

It's too bad the decay-rate isn't tested very thoroughly. Although I
don't have time to do it myself, I think adding a DelayedGroups filter
to the mg_tallies test would be a good start.
2020-11-04 16:58:43 +00:00
Adam Nelson
cf9ce60c89 Added an MGXS.get_flux method to obtain the weighting flux for whatever post-processing the user may need to do 2020-10-28 16:27:52 -05:00
Adam Nelson
d2c00b4f1b Added tests and fixed code accordingly 2020-10-22 14:13:32 -05:00
Adam Nelson
6f4da06580 Added ability to handle ArbitraryMatrixXS types (i.e., we can now create (n,3n) energy transition matrices). This is in addition to the previous commit's incorporation of the same for vector MGXS with the ArbitraryXS type. Also gave the user the ability to request that a domain's macroscopic Chi values be used for all isotopes in a domain. This is important because some codes do not create macroscopic Chi's with flux-weighting of the group-wise fission source, they instead assume a constant group-wise flux. This leads to errors downstream with microscopic MGXS in codes like OpenMC's MG mode and even heavily used production codes like DIF3D. 2020-10-22 09:51:14 -05:00
Adam Nelson
b74c0cc18f Storing state 2020-10-20 16:50:35 -05:00
Adam Nelson
96b580d424 Incorporating changes requested by @giudgiud 2020-10-19 06:35:07 -05:00
Miriam
6b3374a15e Fixed typo in mgxs.py and modified all tests except distribcell 2020-10-07 19:36:03 +00:00
Miriam
679be77c6c Removed extra comments 2020-10-07 18:42:36 +00:00