Commit graph

164 commits

Author SHA1 Message Date
Xinyan Wang
9cf2f22f24
Apply Weight Window Upon Surface Crossing (#2670)
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2023-09-26 05:03:49 +00:00
John Tramm
f46d3ee37c
Streamlined URR PRNG stream selection to avoid unneeded store/load ops (#2689) 2023-09-11 12:26:46 -05:00
Paul Romano
46866cb33a
Check for zero fission cross section before sampling fission reaction (#2600) 2023-08-09 02:07:38 -05:00
Patrick Shriwise
a528de2976
Merge pull request #2381 from paulromano/anisotropic-fission
Use correct direction for anisotropic fission and update numpy version for tests
2023-02-20 12:37:08 -06:00
Paul Romano
956e3f4341 Make sure correct direction is applied when fission neutrons are anisotropic 2023-02-10 11:41:50 -06:00
Paul Romano
5470ec75b4 Avoid out-of-bounds access on index_inelastic_scatter_ 2023-02-06 21:49:43 -06:00
Paul Romano
e83ced88dc Change ncrystal_max_energy to be a global constant 2023-01-11 01:17:53 +07:00
Paul Romano
62af773108 Refactor NCrystal interface code to ncrystal_interface.h/cpp 2023-01-10 17:20:11 +07:00
Paul Romano
b6d6bdf3f5 Merge branch 'develop' into mixed_ncrystal_pr 2023-01-09 13:13:14 +07:00
Paul Romano
f9309bf090 Check for valid binding energy for photoelectric effect 2022-12-05 22:18:41 -06:00
Coline Larmier
ae785fda5f Fix the case where the yield is zero.
Problem detected in the context of a code-to-code comparison between OpenMC and TRIPOLI-4:
- configuration: sphere of radius R = 30 cm containing the isotope ZR93 at 293K
- sphere irradiated at the center by an isotropic, mono-energy, point source (E_0 = 14.1 MeV)
- data from JEFF-3.3

For some isotopes, namely ZR93 at 293K, the sampled yield can be equal to 0 (namely for MT=5: interaction "n-other").
In such a case, it is necessary to deactivate the particle.
2022-11-11 10:47:13 +01:00
Jose Ignacio Marquez Damian
5afcc9e49b Apply clang-format 2022-10-21 10:40:30 +02:00
Jose Ignacio Marquez Damian
2e19260dea Implement recommended changes 2022-10-21 10:40:30 +02:00
Jose Ignacio Marquez Damian
9c54ac0b6b Fix access to private attributes 2022-10-21 10:40:30 +02:00
Jose Ignacio Marquez Damian
0e0cd0a22d Added hooks for NCrystal 2022-10-21 10:40:30 +02:00
myerspat
c38ed4d875 used placeholders namespace and added comment about variables initialized 2022-06-29 09:37:18 -05:00
myerspat
98a7d5eabc added clang format 2022-06-10 11:57:35 -05:00
myerspat
70b1706460 Moved initialized variables into if statement 2022-06-09 10:39:46 -05:00
myerspat
61db44f40e Xtensor for photoelectric cross sections matches the flux spectrum for uranium of the previous iteration of OpenMC 2022-06-09 09:52:50 -05:00
Patrick Myers
687d43b0ab added external xtensor within PhotonInteraction for all shell photoelectric xs to utilize contiguous memory in calculate_xs 2022-05-25 09:06:53 -05:00
Paul Romano
2bb6ba25af Remove alive_ data member on ParticleData 2022-03-01 15:24:39 -06:00
Paul Romano
8d002454f0 Add Reaction::xs methods 2022-02-18 09:54:28 -06:00
Paul Romano
3e6eba4439 Respond to @gridley comments on #1974 2022-02-16 09:34:34 -06:00
Paul Romano
de50a7bfca Generalize russian_roulette function 2022-02-15 11:10:34 -06:00
Paul Romano
f18caa1712 Get rid of wgt_absorb in ParticleData 2022-02-15 11:10:33 -06:00
Paul Romano
f741568d06 Don't modify wgt_last in survival biasing 2022-02-15 11:10:33 -06:00
Paul Romano
72af700ffd
Merge pull request #1947 from pshriwise/ww-final-tests
Weight windows final push
2022-01-19 09:13:07 -06:00
Olaf Schumann
9c7dcbba63 Off by 1 error on Nuclide::cs_cdf
Error occured in regression_tests/resonance_scattering/test.py
2022-01-13 14:29:19 +01:00
Paul Romano
ac495ef0f3 Move main weight window function to weight_windows.cpp 2022-01-08 15:26:02 -06:00
YuanHu-PKU-KIT
e08af3c374 Implement mesh-based weight windows (squashed)
Co-authored-by: Andrew Davis <andrew.davis@ukaea.uk>
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2022-01-08 14:43:18 -06:00
Paul Romano
4831456144 Ensure time is propagated for fission neutrons 2022-01-05 07:43:43 -06:00
amandalund
ba1a39e281 Make atomic_relaxation iterative instead of recursive 2021-10-04 09:31:55 -05:00
Paul Romano
1bc2bd8460 Apply clang-format on entire source 2021-08-11 11:41:49 -05:00
John Tramm
7cc508ea48 spelling fix in warning message. 2021-07-01 18:33:02 +00:00
John Tramm
51b452ec48 applied fix to multigroup mode. 2021-07-01 17:31:40 +00:00
John Tramm
484858dfc1 Added fixes for fission bank overflow memory issue. 2021-07-01 16:24:17 +00:00
Paul Romano
43804fc09d Merge branch 'develop' into rng-stream-changes 2021-05-11 16:53:10 -05:00
Gavin Ridley
061156e79a address PR comments 2021-05-03 18:03:06 -04:00
Gavin Ridley
2af4c9cd92 use base class to handle layout of particle data 2021-05-03 17:57:41 -04:00
Gavin Ridley
d5d2072266 change particle to using accessor methods 2021-05-03 17:56:57 -04:00
Paul Romano
1e1bfb40f1 Add uniform_distribution function for clarity 2021-05-03 09:43:09 -05:00
Paul Romano
e0e5936b79 Remove separate RNG stream for photons 2021-05-03 09:43:09 -05:00
Paul Romano
8a07feebcb Sample isotropic direction consistently 2021-05-03 09:43:09 -05:00
Paul Romano
6ea0c71386 Simplify sample_fission_neutron 2021-05-03 09:43:09 -05:00
Paul Romano
7ef73f048d Remove special treatment of mu for fission 2021-05-03 09:43:09 -05:00
Paul Romano
6650dcf833 Use nu_bank_ for fixed source mode too
Right now, if an outgoing energy filter is used with a nu-fission score in fixed
source mode, OpenMC will segfault because it tries to pull information on
fission sites from nu_bank_, which is not currently populated.
2021-04-28 08:02:47 -05:00
Gavin Ridley
c262407af5
Merge pull request #1746 from paulromano/wmp-performance-opt
Performance optimizations for windowed multipole
2021-01-20 12:59:30 -05:00
YoungHui Park
4e312efdeb Set surf_id of fission bank site with default value 2021-01-18 14:36:05 -06:00
Paul Romano
425de8943f Minor optimizations for WindowedMultipole 2021-01-13 14:57:09 -06:00
Paul Romano
ece6b8b15f Weight non-fission energy deposition by keff 2020-06-29 10:59:14 -05:00