Commit graph

46 commits

Author SHA1 Message Date
Paul Romano
d21b653d32
Refactor MicroXS class and usage in IndependentOperator (#2595)
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
Co-authored-by: Olek <45364492+yardasol@users.noreply.github.com>
2023-08-31 10:55:21 -04:00
Lorenzo Chierici
43437e9410
TransferRates (old msr continuous capabilities) (#2358)
---------

Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
Co-authored-by: Olek <45364492+yardasol@users.noreply.github.com>
Co-authored-by: yardasol <yardasol@grinnell.edu>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Co-authored-by: Gavin Ridley <gavin.keith.ridley@gmail.com>
2023-04-27 22:11:17 -05:00
yardasol
d70ff20118 Merge remote-tracking branch 'origin/microxs-from-model-parallel' into microxs-from-model-parallel 2022-09-11 14:08:06 -05:00
yardasol
15a75284f4 make statements about multiple materials and env vars more precise 2022-09-11 14:03:23 -05:00
Olek
ca12e3656e
Typo and syntax fixes
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2022-09-08 14:02:47 -05:00
yardasol
8cdce03828 cleanup awkward sentences 2022-09-08 12:52:14 -05:00
Olek
a414f5a32a
Apply suggestions from code review
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2022-09-08 12:49:54 -05:00
yardasol
37cfd20498 add paragraph on using env variable w from_model 2022-09-08 11:42:37 -05:00
Paul Romano
2a7a6b171e
Fix flux equation per @yardasol suggestion
Co-authored-by: Olek <45364492+yardasol@users.noreply.github.com>
2022-08-17 09:26:46 -05:00
Paul Romano
6e1e18ab36 Define terms in flux equation for depletion docs 2022-08-16 22:18:55 -05:00
Paul Romano
282c8115df Fix error in equation in depletion user docs 2022-08-16 16:38:21 -05:00
Olek
b93642ff74
fix density variable 2022-08-10 14:32:42 -05:00
yardasol
2144ec271f fix flux equation in depletion userguide 2022-08-10 10:57:23 -05:00
yardasol
672293a310 doc fixes 2022-08-09 23:04:53 -05:00
yardasol
c3921b735f Changes from @paulromano's 6th round of comments
- add more detail to `MicroXS` example in User's Guide
- Cleanup the `from_model` method
- Reduce repeated code between `MicroXS` and `CoupledOperator`
2022-08-04 10:51:38 -05:00
yardasol
65624df58d add chain_file, dilute_initial parameters to MicroXS.from_model 2022-08-03 16:16:19 -05:00
Olek
4a06d14b15
Apply suggestions from code review
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2022-08-02 12:28:00 -05:00
yardasol
89d79310bb revert DepletionOperator to TransportOperator; doc updates 2022-08-01 12:44:28 -05:00
yardasol
78e4e0aedf doc adjustments from @paulromano's comments 2022-08-01 12:20:46 -05:00
yardasol
3e81a86915 TransportOperator->DepletionOperator 2022-07-30 18:37:51 -05:00
yardasol
773757246b Operator->CoupledOperator
- update references in docstrings and docpages
- minor adjustments to related docs in deplete module files
- retain backwards compatiblity by exporint Operator alias
2022-07-30 16:46:31 -05:00
yardasol
ea1e2d02c4 Adjust docpages to accomodate new transport-independent depletion
scheme.
2022-07-30 15:17:16 -05:00
yardasol
3e827530ba make changes from @paulromano's 3rd review
- syntax fixes and adjustments
- change name of FluxDepletionOperator to IndependentOperator
- flux_operator.py -> independent_operator.py
- new class, MicroXS, for creating (for now) one-group microscopic
  cross section DataFrames. This class takes the functionality that was
  previously in static functions in IndependentOperator
- Associated changes to the test suite and online docs
2022-07-28 17:50:06 -05:00
yardasol
4818a296d4 Made changes from paulromano's 2nd round of comments
- Syntax improvements and fixes
- removed `flux` parameter from Integrator
- Moved generate_1g_cross_sections to a top level function in
  flux_operator.py
- changed normalization modes: constant-flux -> source-rate;
  constant-power -> fission-q
- fixed regression tests (fission-q reference solution was bad before,
  but is now much more reasonable and comparable to the source-rate
  reference solution)
- added `nuc_units` parameter to the `from_nuclides` method.
- docstring fixes
- RST doc fixes
- spelling fixes
2022-07-27 13:30:56 -05:00
yardasol
18cc291c9d formatting adjustment in usersguide 2022-07-21 17:52:18 -05:00
yardasol
2f43656f34 update user guide 2022-07-21 12:27:36 -05:00
yardasol
06f34b9f23 address most of paulromano's comments 2022-07-21 11:00:45 -05:00
yardasol
030e14a799 update name of function in example 2022-07-19 12:55:05 -05:00
yardasol
7e671d4e57 Change defualt constructor to accept a Materials object
The classmethod, from_nuclides, retains the volume-nuclide constructor
2022-07-19 12:33:56 -05:00
yardasol
3817750bff fix Operator syntax in UG Chapter 8 example 2022-07-19 12:20:22 -05:00
yardasol
5f8e1ff9d9 Address paulromano's comments
- various syntax adjustments and cleanups
- remove unneeded import statements
- add more information to new section in user's guide
- typo fixes
- remove dilute_initial
- move _validate_micro_xs_inputs back into the class as a static method
- update tests to reflect changes
2022-07-12 11:44:12 -05:00
yardasol
3e5f47b0be Added references to the new class in the docs 2022-07-07 16:22:30 -05:00
Paul Romano
8bfb1889b9 Rename deplete.ResultsList -> deplete.Results 2022-06-03 09:04:00 -05:00
Paul Romano
0b77cc7edc Allow normal instantiation of ResultsList (instead of from_hdf5) 2022-06-03 09:03:57 -05:00
Paul Romano
45a6b31c8f Change StatePoint.k_combined -> keff, ResultsList.get_eigenvalue -> get_keff 2022-05-02 12:09:43 -05:00
Paul Romano
4f9bbca7f3 Add note about specifying volume for depletion 2021-03-17 07:34:01 -05:00
Paul Romano
efbd375fce Add note about depletable attribute in user's guide documentation 2020-08-10 08:03:23 -05:00
Paul Romano
14175b50ed Update depletion documentation to mention fixed-source mode 2020-08-07 11:10:35 -05:00
Paul Romano
32d2aada20 Update documentation (energy_mode -> normalization_mode) 2020-08-03 15:01:09 -05:00
Jiankai Yu
33bb0ecbd8 fix a small typo in unit of fission_q 2020-07-14 10:00:12 -04:00
Paul Romano
4200b0dfbf Update depletion-related documentation 2020-02-12 16:05:58 -06:00
Andrew Johnson
0c97807da8
Clarify documentation on Operator diff_burnable_mats
In PR #1392, it was revealed that the distribution of material
volumes with ``diff_burnable_mats`` was not clear. In that PR,
the Operator now divides the volume of the shared material
equally across all identical and newly created instances.
This commit adds some clarifying language into the Operator
docstring and depletion users guide on the handling
of volumes across repeated materials.
2019-11-08 12:08:57 -05:00
Andrew Johnson
1d08279c02
Respond to reviewer comments on depletion caveats 2019-09-20 13:29:46 -05:00
Andrew Johnson
12201f7361
Add discussion in user's guide on depletion caveats
Potential over-depletion using the fission-q
energy deposition mode and some remedies.

Repeated burnable materials are depleted as a single material
unless diff_burnable_mats=True is given to the Operator
2019-09-19 16:37:26 -05:00
Andrew Johnson
269b3bf2d1
Update user's guide on depletion
Indicate class-based integration, and pull results from file
using `ResultsList.from_hdf5`
2019-09-05 16:50:16 -05:00
Paul Romano
5f001ee6b5 Add a short user's guide section on depletion 2019-06-14 22:22:38 -05:00