Commit graph

76 commits

Author SHA1 Message Date
John Tramm
24fdb84edc
Tally 32-bit Overflow Fix (#3960)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2026-07-02 11:53:49 -05:00
GuySten
3ba8a9f078
Correctly score pulse height tally when no cell filter is present (#3821)
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2026-02-26 02:44:17 +00:00
John Tramm
977ade79a1
Replace xtensor with internal Tensor/View classes (#3805)
Co-authored-by: John Tramm <jtramm@gmail.com>
2026-02-17 09:50:38 -06:00
Gregoire Biot
2d77544b0c
Adding variance of variance and normality tests for tally statistics (#3454)
Co-authored-by: Ethan Peterson <eepeterson3@gmail.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2025-11-12 11:41:37 -05:00
GuySten
afd9d06074
Fixed a bug when combining TimeFilter, MeshFilter, and tracklength estimator (#3525)
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2025-09-12 20:23:17 +00:00
GuySten
a34365396e
Remove unused special accessors for tallies (#3527) 2025-08-11 10:51:45 -05:00
Gavin Ridley
aa4de82258
remove gsl-lite dependency (#3225)
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2025-02-20 01:03:20 +00:00
Christopher Fichtlscherer
e3cd406a9b
Pulse height tally for photons (#2452)
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2023-07-09 22:50:08 -05:00
Patrick Shriwise
610a5d8c34
Global Weight Window Generation via CAPI (#2359)
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
2023-06-09 10:47:27 -05:00
Paul Romano
c123ce0fa0
New multiply_density option on tallies (#2539) 2023-06-09 08:24:00 -04:00
Patrick Shriwise
0a950eb623
Reworking Tally::add_filter a bit (#2501) 2023-05-01 22:00:45 -05:00
Patrick Shriwise
040965245d Adding signatures for reading information from an XML node where necessary. 2022-12-06 13:03:38 -06:00
Lewis Gross
6ef62fcaf1
documentation fix tally.h
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
2022-08-11 13:26:29 -05:00
Lewis Gross
3ff11280a1
documentation fix tally.h
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
2022-08-11 13:26:12 -05:00
lewisgross1296
8140ff492c added some commenting and the extern remove_tally_from_tallies function 2022-08-10 14:23:26 -05:00
Paul Romano
af4a8400c5 Remove archaic 'all' nuclides tally feature 2022-02-22 16:37:53 -06:00
Paul Romano
7969bb1488 Use <gsl/gsl-lite.hpp> include instead of <gsl/gsl> 2021-08-25 13:10:28 -05:00
Paul Romano
1bc2bd8460 Apply clang-format on entire source 2021-08-11 11:41:49 -05:00
helen-brooks
130724e3f7 Small refactor of Tally::set_filters method: create new public method set_strides. 2021-06-15 16:12:01 +01:00
Gavin Ridley
ad4e1c9f4a remove std:: from vector,unique_ptr,make_unique,array 2021-05-03 18:01:27 -04:00
Patrick Shriwise
7b6bf93afd Adding function for retrieving the name of a nuclide from a tally. 2021-04-07 19:07:07 -05:00
Paul Romano
96a66789b1 Activate need_depletion_rx for reaction rate-based depletion only 2020-09-15 10:23:31 -05:00
Patrick Shriwise
f566386661 Various cleanup changes. 2020-03-19 14:15:26 -05:00
Patrick Shriwise
01efd1ef59 Added a function for converting score integers to strings instead of storing them. 2020-03-19 14:15:26 -05:00
Patrick Shriwise
5d18ea67c6 Using score and nuclide strings for a nicer tag name. 2020-03-19 14:15:26 -05:00
Paul Romano
832c32e16a
Merge pull request #1454 from gridley/add_enums2
Attempt number two at enum conversion!
2020-01-21 17:13:35 -06:00
Gavin Ridley
7df7fc280b
Merge branch 'develop' into add_enums2 2020-01-21 13:13:50 -05:00
Paul Romano
21dd56a343 Fix comment in tally.h regarding order of axes for results_ 2020-01-21 07:38:04 -06:00
Paul Romano
1a35632fe3 Ensure Material, Filter, and Tally destructors don't segfault
Because these destructors call erase() on the corresponding maps, they expect
that the maps still exist. However, based on the current order of declaration,
there is no guarantee that they exist because the maps will be deleted first.
2020-01-21 07:34:10 -06:00
Paul Romano
8f52e04735
Merge pull request #1451 from jtramm/no_thread_private
Preparation for event-based parallelism (Thread private variable removal)
2020-01-20 10:45:05 -06:00
Gavin Ridley
9483c409a8 convert all but one thing in cell.h to enums 2020-01-16 15:41:45 -05:00
John Tramm
2ea0859fd3 Removed some comment references to threadprivate variables that no longer exist. 2020-01-14 02:30:17 +00:00
John Tramm
d4c63ed0bb removed thread private global tally accumulators and moved them to particle. They now atomically accumulate at particle death. 2020-01-03 21:09:44 +00:00
Paul Romano
7dd70b6152 Add Tally::add_filter convenience method 2019-12-12 06:59:01 -06:00
Sterling Harper
eabf3e2a86 Merge remote-tracking branch 'upstream/develop' into valgrind 2019-12-04 18:48:18 -05:00
Sterling Harper
57cab6b346 Address some minor Valgrind errors/warnings 2019-12-04 18:44:38 -05:00
Andrew Johnson
484bf70c86
Tally.get_writable() -> Tally.writable()
Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2019-09-30 18:55:42 -04:00
Andrew Johnson
801f18b357
Provide Tally writable_ setter and getters
New member functions openmc::Tally.set_writable and get_writable
act on the writable attribute. These are used in the external
API with openmc_tally_set_writable and openmc_tally_get_writable
functions.

Cleaned up some other writeable -> writable typos as well
2019-09-26 21:09:13 -04:00
Andrew Johnson
7a1a424d0f
Tally.writeable -> Tally.writable
Oops

Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2019-09-26 20:34:11 -04:00
Andrew Johnson
e17687d457
Add openmc::Tally.writeable_ attribute
Boolean flag that indicates if a tally should be written to
output files. This has no effect on tally scoring, but instead
will be used to skip writing Tally data for those not marked
as writeable.

Related to #1327 as the depletion interface will use this flag
to reduce time spent writing reaction rate tallies and also
reducing the size of the final statepoint files
2019-09-19 09:18:26 -05:00
Paul Romano
c68052da6b Reorder declarations in Tally, Filter, and Material classes 2019-07-09 06:43:16 -05:00
Paul Romano
6e9c731b0c Move tally creating logic into Tally::Tally(pugi::xml_node) 2019-07-09 06:43:16 -05:00
Paul Romano
7db1511f00 Add destructors that remove key-value pairs from maps 2019-07-09 06:43:16 -05:00
Paul Romano
b0704a674f Add Tally::set_active method 2019-07-09 06:43:16 -05:00
Paul Romano
9553f2908a Improvements in Tally interfaces 2019-07-09 06:43:16 -05:00
Paul Romano
e1e4941d8c Fix all the bugs introduced 2019-02-21 19:30:07 -06:00
Paul Romano
0439eb0fa1 Convert remainder of tallies to C++ 2019-02-21 19:30:04 -06:00
Paul Romano
d0b6d9fbd6 Move read_tallies_xml to C++ 2019-02-20 23:34:36 -06:00
Paul Romano
3eea8311d3 Move results and global_tallies over to C++ 2019-02-20 15:03:36 -06:00
Paul Romano
1542cf7bfd Remove declaration of global_tally_* values on Fortran side
No more OpenMP in Fortran code!
2019-02-20 15:03:36 -06:00