Commit graph

1672 commits

Author SHA1 Message Date
John Tramm
79bf18efa8 misc small edits. Trying to track down threading bug that causes undefined behavior 2020-01-06 20:52:48 +00:00
John Tramm
69d782f315 broke up history-based method into discrete events 2020-01-03 22:50:41 +00:00
John Tramm
d1b5810688 moved thread private trace debugging variable into particle object. 2020-01-03 21:55:03 +00:00
John Tramm
d4c63ed0bb removed thread private global tally accumulators and moved them to particle. They now atomically accumulate at particle death. 2020-01-03 21:09:44 +00:00
Paul Romano
4ed1d5f42f Allow default material cell offset generation to be turned off 2020-01-02 16:12:04 -06:00
Paul Romano
abe5596cb3
Merge pull request #1337 from shikhar413/cmfd-omp
OpenMP parallelism + minor code cleanup for CMFD
2019-12-17 22:28:46 -06:00
John Tramm
58d10d6a30 increase nubank size from 10 to 15. Some nu values were getting be 10 or 11. Also added an assert to enforce this. 2019-12-16 20:49:16 +00:00
John Tramm
a9dedd48ae added fix for fission tallies, where it would snoop through the (defunct) fission bank for neutrons creaetd in the last reaction. This would required iterating through the entire global fission bank and searching for child particles, which could be super slow. Instead, particles now contain a small nu bank that contains the required information, and is statically sized at 10, as I am assuming nu is always < 10. 2019-12-16 19:55:55 +00:00
John Tramm
f5e2c12681 fixed issue with fixed source problems, where fission neutrons were getting banked to fission bank instead of secondary bank. 2019-12-13 18:05:58 +00:00
Sterling Harper
6a2f3ee2ef Use collective IO for read/write tally results 2019-12-13 11:51:22 -05:00
Sterling Harper
bc08d8a6b8 Explicitly name lowlevel HDF5 read/write dataset 2019-12-12 17:24:03 -05:00
John Tramm
768102ad18 converted tracks to be particle owned, rather than global threadprivate 2019-12-12 22:19:56 +00:00
John Tramm
4fb438cbea moved filter_matches arrays to be particle owned rather than global thread private 2019-12-12 21:09:55 +00:00
John Tramm
38fa90b3e4 Moved flux derivatives to the particle. Diff tallies are still not getting right answer, but they look closer... 2019-12-12 16:02:06 +00:00
Paul Romano
a14e3d98aa Move CellInstance to cell.h 2019-12-12 07:30:41 -06:00
Paul Romano
7dd70b6152 Add Tally::add_filter convenience method 2019-12-12 06:59:01 -06:00
Paul Romano
fb8b1c9b78 Add constructor for CellInstanceFilter. Call prepare_distribcells at simulation
initialization, not program initialization
2019-12-12 06:59:01 -06:00
Paul Romano
e6d2648dc1 Implement cell instance filter 2019-12-12 06:59:01 -06:00
John Tramm
1bb03f004a Moved current_work variable to particle object, and removed threadprivate tag from tally_derivs 2019-12-11 21:58:19 +00:00
John Tramm
70c9b7dd51 added skip of CMFD tests that cause seg faults 2019-12-11 19:55:28 +00:00
John Tramm
796844fd0b fixed broken stuff from prn interface changes 2019-12-11 16:09:15 +00:00
John Tramm
c49ce141a7 fixed MPI issues that resulted from adding Bank struct member 2019-12-11 16:07:33 +00:00
John Tramm
6050e705bc fixed reproducibility issue 2019-12-11 16:06:04 +00:00
John Tramm
ff27ed2bbe made secondary particle bank particle owned instead of thread private 2019-12-11 16:00:10 +00:00
Paul Romano
bc42e5ccf7
Merge pull request #1419 from jtramm/particle_owned_seeds
Particle owned random number state variables
2019-12-06 14:49:23 -06:00
John Tramm
c84fc282a5 Moved seed accessor functions into header. Changed python rotate_angle default seed generation technique. 2019-12-06 14:56:42 +00:00
John Tramm
0602ddd8a3 refactor seed and seed aray variable names 2019-12-05 19:50:31 +00:00
John Tramm
428bab4fd2 incorporated code review changes 2019-12-05 19:32:12 +00:00
Sterling Harper
eabf3e2a86 Merge remote-tracking branch 'upstream/develop' into valgrind 2019-12-04 18:48:18 -05:00
Sterling Harper
57cab6b346 Address some minor Valgrind errors/warnings 2019-12-04 18:44:38 -05:00
John Tramm
e88f7c830c added back in extern C tag for get_seed() and set_seed() functions that are called from python 2019-12-04 17:23:57 +00:00
John Tramm
0c98e8d788 whitespace cleanup and comment fixes 2019-12-04 17:09:32 +00:00
John Tramm
28edfc5021 removed extern C identifiers from random_lcg functions 2019-12-04 17:01:35 +00:00
John Tramm
638172e68d refactor of prn() interface and python interface changes 2019-12-04 16:35:01 +00:00
John Tramm
2ec02d6472
Apply formatting fixes from code review
Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
2019-12-03 10:36:01 -06:00
Paul Romano
eca3ce33d2 Fix pointer placement on uint64_t 2019-11-27 07:04:11 -06:00
John Tramm
60015e5c5c Revert "Merge branch 'event-based-device' into particle_owned_seeds"
This reverts commit 12463ac6b0, reversing
changes made to 4261690537.
2019-11-26 17:05:04 +00:00
John Tramm
12463ac6b0
Merge branch 'event-based-device' into particle_owned_seeds 2019-11-26 10:47:10 -06:00
John Tramm
4261690537 finished refactoring to add class member signifier, and finished formatting cleanup 2019-11-25 16:28:07 +00:00
John Tramm
12ec9bacff cleanup of comments and adding some parameter descriptions for altered function prototypes 2019-11-22 22:56:16 +00:00
John Tramm
44ba6805dc added seeds to the plotting model namespace so that if multiple plots are called, they will have different colors 2019-11-22 18:23:16 +00:00
John Tramm
ecb5f828d2 removed some comments. Also attempted to fix the math unit tests that now require direct passing of seeds and stream variables 2019-11-22 16:17:46 +00:00
John Tramm
3b985f1976 finished debugging. Appears to get the same answer on the pincell. Lets see if it passes tests. 2019-11-22 15:13:09 +00:00
John Tramm
674585c8fe changed N_STREAMS to const defined in header rather than random_lcg.cpp 2019-11-21 23:28:15 +00:00
John Tramm
642c3a8ac7 first sweep of refactoring is complete. now for debugging 2019-11-21 23:03:52 +00:00
John Tramm
5502f38580 partially done with refactoring 2019-11-21 22:19:15 +00:00
John Tramm
0ebfae4ef5 added particle based seed initialization. Now for sampling functions to use the new seeds. 2019-11-20 22:55:40 +00:00
John Tramm
5c7e7ff13f changed basic prototypes 2019-11-20 19:20:03 +00:00
John Tramm
8c1ebbd7fb initial SHM fission bank has been implemented. Needs debugging. 2019-11-19 22:04:01 +00:00
John Tramm
54698ec7da
Merge pull request #3 from openmc-dev/develop
CI
2019-11-18 08:20:52 -06:00