Commit graph

11743 commits

Author SHA1 Message Date
Patrick Shriwise
f6e1d64bea Re-adding GitHub token to CI file -- used to push coveralls results. 2020-12-14 16:56:58 +00:00
Patrick Shriwise
1f0d53f693 Removing unecessary variables in environment. 2020-12-14 16:25:41 +00:00
Patrick Shriwise
1734a07295 Adding message passing header to the C++ driver test. 2020-12-14 06:18:41 +00:00
Patrick Shriwise
793f425372 Updating ubuntu version. 2020-12-14 05:50:03 +00:00
Patrick Shriwise
37944edd95 Adding a GitHub actions CI file. 2020-12-14 05:48:54 +00:00
Adam Nelson
7505718806
Merge pull request #1718 from mkreher13/transient-rewrite
Fixed several bugs related to decay-rate
2020-12-11 10:26:42 -06:00
Amanda Lund
7cc62d8529
Merge pull request #1722 from paulromano/element-fix-jeff33
Fix issue with assigning elemental carbon when using JEFF 3.3
2020-12-08 10:22:53 -06:00
Paul Romano
f952fa9cbc
Merge pull request #1729 from shikhar413/cmfd_reweight_cpp
Move cmfd_reweight function from Python to C++
2020-12-03 12:17:11 -06:00
Shikhar Kumar
d630746191 Address @paulromano comments 2020-12-03 10:37:13 -05:00
Shikhar Kumar
2931ebef9e Confirm precision differences between Python and C++ 2020-11-24 23:44:38 -05:00
Shikhar Kumar
e87e5ba3dc Move CMFD reweight to cpp, minor discrepancies in regression tests 2020-11-24 22:56:31 -05:00
Paul Romano
2115cae40a
Merge pull request #1724 from pshriwise/rp_fix
Typo fix in RectangularParallelepiped.__pos__ method.
2020-11-12 21:44:44 -06:00
Patrick Shriwise
654d27a3e5 Typo fix in RectangularParallelepiped.__pos__ method. 2020-11-12 12:43:40 -06:00
Paul Romano
a117694930 If some natural isos are missing when adding element, check '0' nuclide first 2020-11-11 11:17:35 -06:00
April Novak
88fb7b0349
Merge pull request #1721 from paulromano/check-mesh-spec
Make sure <dimension> is specified on a mesh
2020-11-10 23:09:07 -06:00
Paul Romano
d05bf7789d Move check for consistent shape/lower_left on regular mesh 2020-11-10 21:43:13 -06:00
Patrick Shriwise
b7582e28ab
Merge pull request #1720 from paulromano/autodoc-fix
Fix documentation for several classes
2020-11-10 14:13:34 -06:00
Paul Romano
4b21307128 Make sure <dimension> is specified on a mesh 2020-11-10 14:09:44 -06:00
Paul Romano
7a505613d1
Merge pull request #1705 from nelsonag/mt_mgxs
MGXS API Changes for Arbitrary Reaction Channels and for Accurate Chi Computation
2020-11-10 07:37:00 -06:00
agnelson
a9ebadaecc Fixing comments per the review by @paulromano 2020-11-09 15:59:23 -06:00
Patrick Shriwise
bf1c35e23e
Merge pull request #1706 from paulromano/sourcefile-improve
Refactoring of source classes
2020-11-09 15:14:58 -06:00
Paul Romano
d276fb590d Avoid mocking many third-party packages when building documentation 2020-11-09 14:33:29 -06:00
Andrew Johnson
d7aaf003bb
Merge pull request #1719 from kingyue737/diff_material
Fix the way that depletion operator distributes burnable materials
2020-11-06 08:08:48 -08:00
Yue JIN
3ee40ea37c Distribute depletable materials in all cell instances containing it. 2020-11-05 10:18:26 +08:00
Miriam
954450a841 Fixed several bugs related to decay-rate
1) In mdgxs.py, DecayRate, get_xs(). There is no need to reverse the order
since there isn't an energy group filter anymore. Also, the new_shape
addition formats the cross section like all the others. I updated
mgxs_library_hdf5 test results accordingly.

2) In material.cpp. If you use a macroscopic dnesity other than 1.0,
the code still pushed back '1.0'. My change fixes that. Using a macro
density other than 1.0 wasn't tested anywhere, so I modifed mg_convert
to take a density of 1.1. The default macro density of 1.0 is used in
many other tests.

3) tally_scoring.cpp. Notice that the score is accumulated, then sent
to the function score_fission_delayed_dg where the tally is accumulated.
This amounts to "double accumulation". It makes sense to accumulate the score
over the delayed groups if there is no delayed group filter, but in this
case, when delayed group filter is not None, the score needs to reset
each time.

In other parts of SCORE_DECAY_RATE, I think the distinction between
accumulating and resetting the score is correct. The only place I wasn't
sure was line 1057 (and its equivalent in multi-group, line 1962).

It's too bad the decay-rate isn't tested very thoroughly. Although I
don't have time to do it myself, I think adding a DelayedGroups filter
to the mg_tallies test would be a good start.
2020-11-04 16:58:43 +00:00
Andrew Johnson
e91a6aac17
Merge pull request #1715 from paulromano/add-missing-import
Add missing import in depletion module
2020-11-02 19:45:03 -08:00
Paul Romano
f603644212 Add missing 'import sys' in helpers.py 2020-11-02 15:26:08 -06:00
Paul Romano
e11364257c
Merge pull request #1712 from pshriwise/h5py_update
Update Dataset.value calls for h5py v3.0
2020-10-31 12:23:06 -05:00
Patrick Shriwise
2d94535627 Another .value replacement in the track-to-vtk script. 2020-10-31 00:20:00 -05:00
Patrick Shriwise
1e2735df93 Updating h5py calls in the plot test files. 2020-10-30 23:20:05 -05:00
Adam Nelson
a83e7fa0b7 Reduced number of tested MGXS types in mgxs_library_no_nuclides and mgxs_library_nuclides in an effort to test the intended Python code but not over-do Travis' effort 2020-10-30 07:56:50 -05:00
Adam Nelson
5a94e66bf3 Merge remote-tracking branch 'upstream/develop' into mt_mgxs 2020-10-29 08:34:17 -05:00
Paul Romano
126cbab090
Merge pull request #1710 from pshriwise/rm_ci_static_bld
Remove MOAB Static Library Build
2020-10-29 06:41:14 -05:00
Paul Romano
ed45d6ee77
Merge pull request #1678 from Shimwell/adding-dockerhub-publish-dev
added git actions workflow file
2020-10-28 23:03:04 -05:00
Adam Nelson
cf9ce60c89 Added an MGXS.get_flux method to obtain the weighting flux for whatever post-processing the user may need to do 2020-10-28 16:27:52 -05:00
Patrick Shriwise
c9a95f0ac8 Indicate no build of static libraries for DAGMC. 2020-10-28 12:29:26 -05:00
Patrick Shriwise
86a6e63236 Removing static library build of MOAB. Not required any longery by DAGMC (thank goodness). 2020-10-27 21:11:52 -05:00
Paul Romano
b57ee1f757
Fix class name in comment in source.cpp
Co-authored-by: DanShort12 <66615563+DanShort12@users.noreply.github.com>
2020-10-27 16:03:11 -05:00
Paul Romano
9af5541e88 Make Source::sample() method const 2020-10-27 10:02:03 -05:00
Paul Romano
b271399f63 Allow read_source_bank to be distributed or not 2020-10-27 10:02:00 -05:00
Paul Romano
33b7dcfe22 Update documentation regarding custom sources 2020-10-23 14:11:34 -05:00
Paul Romano
0bb39005bc Rename source classes 2020-10-23 14:11:34 -05:00
Paul Romano
f2526ec439 Generalize source bank reading (don't rely on work_index) 2020-10-23 14:11:30 -05:00
Paul Romano
5a60133d5b Implement SourceFile derived from SourceDistribution 2020-10-23 06:56:14 -05:00
Paul Romano
3f62fab565 Add wrapper class for custom sources 2020-10-22 15:50:30 -05:00
Paul Romano
713469bf59 Make regular source distributions obey the same interface as custom sources 2020-10-22 15:07:28 -05:00
Paul Romano
8f71ed2a1d Store sites from source file in SourceDistribution 2020-10-22 15:07:23 -05:00
Adam Nelson
d2c00b4f1b Added tests and fixed code accordingly 2020-10-22 14:13:32 -05:00
Adam Nelson
6f4da06580 Added ability to handle ArbitraryMatrixXS types (i.e., we can now create (n,3n) energy transition matrices). This is in addition to the previous commit's incorporation of the same for vector MGXS with the ArbitraryXS type. Also gave the user the ability to request that a domain's macroscopic Chi values be used for all isotopes in a domain. This is important because some codes do not create macroscopic Chi's with flux-weighting of the group-wise fission source, they instead assume a constant group-wise flux. This leads to errors downstream with microscopic MGXS in codes like OpenMC's MG mode and even heavily used production codes like DIF3D. 2020-10-22 09:51:14 -05:00
Patrick Shriwise
5b81083742
Merge pull request #1691 from paulromano/sourcesite-python
Generation of source files from Python
2020-10-21 16:42:42 -05:00